Conversation
Enforce server-side admin authorization, trap dispute-modal focus, paginate documents, and restore the last viewed map parcel across navigation. Closes CodeGirlsInc#1301 Closes CodeGirlsInc#1302 Closes CodeGirlsInc#1303 Closes CodeGirlsInc#1304
|
@phertyameen is attempting to deploy a commit to the Mftee's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@phertyameen Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
# Conflicts: # backend/.env.example # backend/src/auth/auth.controller.spec.ts # backend/src/auth/auth.controller.ts # backend/src/auth/auth.service.ts # backend/src/auth/strategies/github.strategy.ts # backend/src/auth/strategies/google.strategy.ts # backend/src/auth/strategies/jwt.strategy.spec.ts # backend/src/auth/strategies/jwt.strategy.ts # backend/src/common/cors.config.ts # backend/src/mail/mail.service.ts # backend/src/main.ts # frontend/app/[locale]/(protected)/admin/providers/page.tsx # frontend/app/[locale]/(protected)/admin/users/page.tsx # frontend/app/[locale]/(protected)/disputes/[id]/page.tsx # frontend/app/[locale]/(protected)/disputes/page.tsx # frontend/app/[locale]/(protected)/settings/data/page.tsx # frontend/app/[locale]/2fa/setup/page.tsx # frontend/app/[locale]/2fa/verify/page.tsx # frontend/app/[locale]/forgot-password/page.tsx # frontend/app/[locale]/login/LoginForm.tsx # frontend/app/[locale]/reset-password/page.tsx # frontend/app/[locale]/verify-email/page.tsx # frontend/app/layout.tsx # frontend/components/LanguageSwitcher.tsx # frontend/components/disputes/FileDisputeModal.tsx # frontend/components/map/ParcelSidebar.tsx # frontend/lib/api-client.ts # frontend/lib/auth-session.ts # frontend/lib/session-expiry-warning.ts # frontend/middleware.ts # frontend/test-utils/LoginForm.test.tsx # frontend/test-utils/api-client.test.ts # frontend/test-utils/language-switcher.test.tsx # frontend/test-utils/mocks/handlers.ts
yusuftomilola
left a comment
yusuftomilola
left a comment
There was a problem hiding this comment.
Reviewed and resolved a large conflict against main: PR #1415 (auth hardening) had independently merged a competing cookie/session scheme right before this landed. Kept main's already-deployed auth-cookie approach and backported this PR's actual contribution — the missing admin-role gate in middleware.ts (main was only checking authentication, not the admin role, on /admin routes), plus the dispute-modal focus containment (now using the shared Dialog primitive), the last-viewed-map-parcel restore/clear wiring, and the FileDisputeModal validation. Dropped the now-dead access-token.ts/session-cookie.config.ts/oauth-exchange-code files and the no-op preferredLanguage backend call (no matching endpoint exists). Good catch on the admin bypass gap.
3 participants
Summary
Issues
Validation
Closes #1301
Closes #1302
Closes #1303
Closes #1304