Fix/1324 1329 1330 1331 notfound locale bak lhci parcel type - #1421
Merged
mftee merged 3 commits intoSep 25, 2026
Conversation
|
@abdoolyaro Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@abdoolyaro is attempting to deploy a commit to the Mftee's projects Team on Vercel. A member of the Team first needs to authorize it. |
next.config.ts.bak was an out-of-date snapshot of next.config.ts (it predates the security headers block) sitting alongside the real config with no explanation. It isn't referenced by any build step or tooling, so it's leftover clutter rather than an intentional backup. Removed.
…1330) .lighthouserc.json only exercised "/" and "/verify", leaving out /map -- the heaviest page in the app (Leaflet + tile layer + marker rendering) and the one most likely to regress on performance. Added it to the collected URLs so it's covered by the same accessibility/performance assertions as the other routes.
…eGirlsInc#1331) DocumentStatus and ParcelDocument were defined inline in ParcelSidebar.tsx with no home in the shared types directory, so any future consumer of the parcel shape would have had to copy it by hand instead of importing a canonical type. Moved both into types/parcel.ts and re-exported them from ParcelSidebar.tsx for backward compatibility with any existing imports.
abdoolyaro
force-pushed
the
fix/1324-1329-1330-1331-notfound-locale-bak-lhci-parcel-type
branch
from
September 25, 2026 06:26
8212352 to
8b42d66
Compare
mftee
approved these changes
Sep 25, 2026
mftee
left a comment
mftee
left a comment
Contributor
There was a problem hiding this comment.
Small, clean cleanup: removes the stray next.config.ts.bak, extracts the ParcelDocument/DocumentStatus types into types/parcel.ts with a backward-compatible re-export, and adds /map to the lighthouse CI targets. No concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1324
closes #1329
closes #1330
closes #1331