feat(polls): add GET /api/polls/:pollId with authoritative results - #159
Open
vedant7007 wants to merge 1 commit into
Open
vedant7007 wants to merge 1 commit into
vedant7007 wants to merge 1 commit into
Conversation
New single-poll endpoint returning the poll plus computed results whose percentages always sum to 100 via largest-remainder (Hamilton) rounding (the client rounds each independently, so even 3-way polls render 99%). Core is a pure, unit-tested computePollResults util. Backend-only, no new dependency. Closes CodePlaygroundHub#158
|
@vedant7007 is attempting to deploy a commit to the Akash Santra 's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #158.
There was no single-poll endpoint, and percentages were computed only client-side (
PollBubble.jsx), rounding each option independently — so an even 3-way poll shows 33+33+33 = 99%. This adds an authoritative server-side endpoint.Changes (backend-only)
backend/src/lib/pollResults.js(new, pure) —computePollResults(poll)→{ totalVotes, options: [{ _id, text, voteCount, percentage }], leadingOptionId }. Percentages use the largest-remainder (Hamilton) method so they sum to exactly 100 (all 0 when there are no votes). No DB/socket/request — pure.poll.controller.js—getPollById(GET /api/polls/:pollId): 400 invalid id, 404 missing, 403 non-member (reusingisGroupMember), else the poll +results. MirrorsgetGroupPollsexactly.poll.routes.js— route registered afterGET /groups/:groupId(no path collision).Testing
backend/test/poll/pollResults.test.js— 5 cases (no votes, even 2-way, 3-way summing to 100, 6-way summing to 100, clear leader).npm test→ 5/5.npm run lint→ 0 errors (my files add none). No new dependency.Contributing as part of Elite Coders Summer of Code (ECSoC 2026).