[codex] AITRAX-581 support immutable standalone Live images - #215
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for immutable (digest-based) container image references in the Live Helm chart and tightens A/V (coturn/Jitsi) rendering so disabling av.enabled fully suppresses related Secrets, annotations, and env configuration.
Changes:
- Introduces
image.digestin values/docs and updates the Deployment template to userepository@digestwhen provided. - Gates the coturn Secret, its checksum annotation, and coturn/Jitsi env vars on
av.enabled(in addition to existing A/V sub-settings). - Bumps chart version to
1.4.26and documents the new value.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/live/values.yaml | Adds image.digest value and documentation comment. |
| charts/live/templates/secret-coturn.yaml | Wraps coturn Secret rendering behind av.enabled + stunServers.enabled. |
| charts/live/templates/deployment.yaml | Adds digest-based image selection and gates coturn checksum/env + Jitsi env on av.enabled. |
| charts/live/README.md | Documents image.digest in the values table. |
| charts/live/Chart.yaml | Bumps chart version to 1.4.26. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
codetogether/codetogether:latestdefault.av.enabledswitch.1.4.26and documentimage.digest.Why
Standalone promotion is digest-based, but the chart previously accepted only mutable tags. It also rendered the coturn Secret unconditionally and could render nested A/V configuration while A/V was globally disabled.
Impact
Existing values remain compatible. Standalone deployments can select an immutable promoted digest, and
av.enabled: falsenow guarantees that no coturn Secret or Jitsi/coturn configuration is rendered.Checks
CT_AV_ENABLED=false, no coturn/Jitsi Secret or configurationrepository@sha256:...and ignores taggit diff --checkRelated build/artifact-contract PR: CodeTogether-Inc/live#525