London | 26-ITP-May | Boualem Larbi Djebbour | sprint 1 | Coursework#1312
Open
djebsoft wants to merge 71 commits into
Open
London | 26-ITP-May | Boualem Larbi Djebbour | sprint 1 | Coursework#1312djebsoft wants to merge 71 commits into
djebsoft wants to merge 71 commits into
Conversation
Updated comment to clarify the assignment operation.
Updated the initials variable to dynamically generate initials from first, middle, and last names.
Implemented logic to extract directory and extension from filePath.
Added comments to explain the purpose and behavior of the num variable and the random number generation process.
Changed 'const' to 'let' for age variable to allow reassignment.
Fix variable declaration order to avoid reference error.
Updated last4Digits assignment to convert cardNumber to a string before slicing.
Updated variable names to avoid starting with digits.
Fixed syntax error in priceAfterOneYear assignment and updated comments.
Added comments to explain the purpose of each step in the code.
Updated the capitalise function to fix variable redeclaration and corrected the return variable name.
Declare 'result' with 'let' to avoid redeclaration error.
…ge function Removed duplicate declaration of decimalNumber and updated comments.
Corrected the square function to properly accept a parameter and return its square.
Refactored multiply function to include return statement and improved logging.
Fix the sum function to correctly return the sum of two numbers.
Corrected the getLastDigit function to accept a parameter and return the last digit of a number.
Added a function to convert a string to upper snake case.
Updated comments in time-format.js to clarify the behavior of the pad function.
Removed comments with answers to questions about the pad function.
Refactor toPounds function for reusability and clarity.
Removed the upperSnakeCase function implementation and example call.
Fix the sum function to return the correct result.
Corrected the square function to properly accept a parameter and return its square.
Updated comments to clarify errors and provide explanations.
Removed duplicate variable declaration and fixed typo in return statement.
This reverts commit 3bb9ddf.
This reverts commit 177c368.
This reverts commit 5809aee.
This reverts commit 4fdfb07.
This reverts commit bbdcc95.
This reverts commit 895a3ad.
This reverts commit 0714db2.
This reverts commit 64c8174.
This reverts commit 0714db2.
This reverts commit a7d7dfd.
This reverts commit 99f2a39.
This reverts commit ce5e2ad.
This reverts commit 0d3adae.
This reverts commit 5196c63.
This reverts commit 56b74d5.
This reverts commit bbdcc95.
This reverts commit 3bcd5ba.
This reverts commit 0d3adae.
djebsoft
added
the
Needs Review
cjyuan
added
Complete
Contributor
|
Previously reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR previously discussed in #1090
changes since last PR: no changes