West Midlands | ITP-26-May| Alina Sofragiu | Sprint 3 | Dead Code#1462
Open
sofragiualina wants to merge 2 commits into
Open
West Midlands | ITP-26-May| Alina Sofragiu | Sprint 3 | Dead Code#1462sofragiualina wants to merge 2 commits into
sofragiualina wants to merge 2 commits into
Conversation
sofragiualina
added
📅 Sprint 3
Luro91
added
the
Review in progress
Luro91
reviewed
Jul 9, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Good job you got removed most of the redundant or dead code. I have one comment where you can improve the code a bit
| console.log(greetingStr); | ||
| } | ||
|
|
||
| testName = "Aman"; |
There was a problem hiding this comment.
How could the code be changed so that this line is not needed but the variable is still set to "Aman"?
Author
There was a problem hiding this comment.
I changed the initial value and removed the later reassignment, thank you for your review
Luro91
added
Reviewed
Updated testName variable to use 'Aman' instead of 'Jerry'.
sofragiualina
added
Needs Review
Luro91
reviewed
Jul 10, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done. The code is now cleaner and does not contain any parts that are not needed
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Removed unused code