London | 26-ITP-May | Dipa Sarker | Sprint 3 | Practice TDD#1471
Open
Dipa-Sarker wants to merge 6 commits into
Open
London | 26-ITP-May | Dipa Sarker | Sprint 3 | Practice TDD#1471Dipa-Sarker wants to merge 6 commits into
Dipa-Sarker wants to merge 6 commits into
Conversation
Dipa-Sarker
added
the
Needs Review
tiakavousi
added
Review in progress
tiakavousi
reviewed
Jul 9, 2026
There was a problem hiding this comment.
Great suite of test cases, can we think of some more edge cases to test, making sure the function can handle tricky arguments?
tiakavousi
reviewed
Jul 9, 2026
There was a problem hiding this comment.
Readability and naming are spot on!
I'm curious about the control flow choices here. Could you share why you opted for the else if chain and wrapped the final return in an else block?
tiakavousi
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist