Small fixes#1485
Open
Liam310 wants to merge 9 commits into
Open
Conversation
In the interest of providing code snippets that follow good practices we advocate for, I think all these variable declarations should be const as there's no reason for them not to be.
The purpose of this challenge is to explore using the console, not to figure out how to find it
This edit attempts to set trainees of on the right foot, exhibiting good practices in our boilerplate code for them to build on.
illicitonion
approved these changes
Jul 9, 2026
illicitonion
left a comment
illicitonion
left a comment
Member
There was a problem hiding this comment.
LGTM - let's wait until August to merge this so that the current cohort have a consistent experience (and their PRs don't end up with merge conflict warnings which can be scary/confusing)?
Co-authored-by: Daniel Wagner-Hall <daniel@codeyourfuture.io>
Author
|
I will put a note to merge this in August 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A series of small fixes to this module's coursework, including:
Sprint-1/1-key-exercises/2-initials.jsandSprint-3/4-stretch/password-validator.js. The changes here don't undermine the aim of the tasks but avoid presenting practices (e.g. usingletwhenconstis more appropriate) that we wouldn't want trainees to internaliseSprint-1/4-stretch-explore/chrome.mdandSprint-3/4-stretch/README.mdcalculateBMIinSprint-2/3-mandatory-implement/1-bmi.js. Currently it says in one place that the "result will be displayed to 1 decimal place" but in another place just says to "return their BMI to 1 decimal place". I don't have have strong feelings as to whether this function ought to return a number or a string, so I opted for explicitly stating a string here to keep along the lines of the result actually being displayed to 1 decimal place