Repository navigation
Cape Town | 26-ITP-Sep | Quentin Gwele | Sprint 2 | coursework/practice-TDD - #1688
Open
lwandogwele52-ui wants to merge 6 commits into
Open
lwandogwele52-ui wants to merge 6 commits into
lwandogwele52-ui wants to merge 6 commits into
Conversation
lwandogwele52-ui
added
the
Needs Review
hackertainment
added
Review in progress
hackertainment
left a comment
hackertainment
left a comment
There was a problem hiding this comment.
The code generally looks good to me. Please keep it up.
hackertainment
added
Reviewed
lwandogwele52-ui
added
the
Complete
|
This PR has not been completed, as I didn't see test cases have been added regarding the following comments:
Can you check whether your updates has been staged and committed? Thanks a lot. |
hackertainment
removed
the
Complete
Author
|
I've added the requested tests for count and repeat-str, pushed them, and replied in each thread. Please take another look. |
lwandogwele52-ui
added
the
Needs Review
|
Congratulation, you have completed this PR successfully. If you would like to learn more about test cases design process (i.e. using minimum number of tests to provide maximum coverage of cases), please feel free to book a mentored coding session with a volunteer. :-) |
hackertainment
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1060
Changelist
Finished all files.