London | 26-ITP-Sep | Mars Adesina | Sprint 2 | Implement and rewrite tests by marscancode · Pull Request #1718 · CodeYourFuture/Module-Structuring-and-Testing-Data

marscancode · 2026-10-15T23:47:00Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1059

Changelist

I implemented the three functions:

getAngleType
isProperFraction
getCardValue
I also created tests in Node and Jest for all three functions.

cjyuan · 2026-10-23T13:13:27Z

@@ -1,3 +1,3 @@
 import { isProperFraction } from "../implement/2-is-proper-fraction.js";

 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.


The test cases in this script do not yet include cases involving negative numbers.

Are $\frac{-2}{3}$, $\frac{2}{-3}$ (which equals to $-\frac{2}{3}$) and $\frac{-2}{-3}$ (which equals to $\frac{2}{3}$) proper fractions? What is the definition of proper fraction?

I've now included tests for negative numbers. Thankyou!

cjyuan · 2026-10-23T13:24:59Z

+  test("Arbitrary non-card string", () => {
+    expect(() => getCardValue("invalid")).toThrow(
+      /Expected a valid number followed by a suit, but got "invalid"/
+    );


Why test the error message as

expect(() => getCardValue("invalid")).toThrow( /Expected a valid number followed by a suit, but got "invalid"/ );

instead of as

expect(() => getCardValue("invalid")).toThrow( 'Expected a valid number followed by a suit, but got "invalid"' );

?

For some reason, I thought this was the syntax used when using .toThrow in jest but i will update with the correct syntax now. Thankyou!

Could you use an AI to find out

The difference and similarity between these two types of argument when using Jest's expect.toThrow()?

How to perform an exact match of the error message with Jest expect.toThrow()?

cjyuan · 2026-10-23T13:26:27Z

Tests are very comprehensive. Excellent job.

…ts now pass

cjyuan

Changes look good.

cjyuan · 2026-10-25T13:01:39Z

@@ -1,3 +1,4 @@
+import { get } from "node:http";


Why import get? Where is it used?

cjyuan · 2026-10-25T13:35:49Z

+test(`proper fraction with a negative numerator but positive denominator`, () => {
+  expect(isProperFraction(-2, 3)).toEqual(true);
+});
+
+test(`proper fraction with a positive numerator but negative denominator`, () => {
+  expect(isProperFraction(2, -3)).toEqual(true);
+});
+
+test(`proper fraction with both a negative numerator and denominator`, () => {
+  expect(isProperFraction(-2, -3)).toEqual(true);
+});


Note: Rather than writing a separate test for each sign combination, you could consider grouping inputs that exercise the same behaviour into one test, under a test description that is applicable to all. For example,

test("should return true when abs(numerator) < abs(denominator)", () => { expect(isProperFraction(1, 2)).toEqual(true); expect(isProperFraction(-1, 2)).toEqual(true); expect(isProperFraction(1, -2)).toEqual(true); expect(isProperFraction(-1, -2)).toEqual(true); });

Note: Use of widely recognised pseudo-code and math notations like abs(...) or | ... | in the descriptions is an usually accepted.

No change required

marscancode added 24 commits October 13, 2026 13:55

implemented getAngleType function

3c34300

implemented right angle classification

a3e94a4

added Obtuse angle test

e24692a

added straight angle test it fails

9aafc79

implemented classification for straight angle test now passes

db06ff6

added reflex angle test and it fails

2e539b5

implemented classification for reflex angle test now passes

874aa37

added test for invalid angles it fails

190c45b

added test for acute angle

5bf0d70

refactored acute angle implementation

9faf227

added additional acute angle tests

b7ac8b6

refactored aditional acute angle tests

f5f0c00

added additional tests for obtuse angles

780ce9a

added additional tests for reflex angles

d242353

added additonal tests for invalid angles

ff0d518

added final test for invalid angle 360

f049f47

added final acute angle test for 1

036f167

added jest tests

8631a7e

added tests in node for isProperFraction function

7797f0c

Implemented isProperFraction function

5651ef6

added tests in jest for the isProperFraction function

d47c1c7

Implemented getCardValue function

57a3aba

added node tests for getCardValue function

7d65d6f

added jest test for getCardValue function

f989cbd

marscancode added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Structuring-And-Testing-Data The name of the module. labels Oct 15, 2026

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 23, 2026

cjyuan reviewed Oct 23, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 23, 2026

marscancode added 4 commits October 25, 2026 08:47

added negative number tests for isProperFraction

8d09a15

refactored isProperFraction function to handle negative numbers, tes…

728add3

…ts now pass

added negative tests in jest for the isProperFraction, tests pass

122cf3c

fixed syntax on toThrow error messages

d7789c6

marscancode added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 25, 2026

cjyuan reviewed Oct 25, 2026

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 25, 2026

Navigation Menu

Repository navigation

London | 26-ITP-Sep | Mars Adesina | Sprint 2 | Implement and rewrite tests - #1718

London | 26-ITP-Sep | Mars Adesina | Sprint 2 | Implement and rewrite tests#1718
marscancode wants to merge 28 commits into
CodeYourFuture:mainfrom
marscancode:coursework/sprint-3-implement-and-rewrite

marscancode commented Oct 15, 2026

Uh oh!

Uh oh!

cjyuan Oct 23, 2026

Uh oh!

marscancode Oct 25, 2026

Uh oh!

cjyuan Oct 23, 2026 •

edited

Loading

Uh oh!

marscancode Oct 25, 2026 •

edited

Loading

Uh oh!

cjyuan Oct 25, 2026

Uh oh!

cjyuan Oct 23, 2026

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Oct 25, 2026

Uh oh!

cjyuan Oct 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1,3 +1,3 @@
		import { isProperFraction } from "../implement/2-is-proper-fraction.js";

		// TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.

Conversation

marscancode commented Oct 15, 2026

Learners, PR Template

Task code

Changelist

Uh oh!

Uh oh!

cjyuan Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

marscancode Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marscancode Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cjyuan Oct 23, 2026 •

edited

Loading

marscancode Oct 25, 2026 •

edited

Loading