Repository navigation
London | 26-ITP-Sep | Shirin Panahian | Sprint 2 | Practice TDD - #1721
Open
shirinpanahian wants to merge 6 commits into
Open
shirinpanahian wants to merge 6 commits into
shirinpanahian wants to merge 6 commits into
Conversation
shirinpanahian
added
the
Needs Review
hackertainment
added
Review in progress
hackertainment
left a comment
hackertainment
left a comment
There was a problem hiding this comment.
Thank you for your coursework. Please fix the ordinal number program and the test cases.
There was a problem hiding this comment.
This program seems not quite right to me. Why input cannot be ended with 11 or 22 or 33 ? They should all be valid. Please check the definition of ordinal number carefully, and fix the program (with test cases). Thank you.
Author
There was a problem hiding this comment.
Thanks for the feedback! I've corrected the ordinal number tests to handle the special cases ending in 11, 12, and 13, and added test cases for numbers ending in 22 and 33 to ensure they return nd and rd respectively.
hackertainment
added
Reviewed
shirinpanahian
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1060
Changelist
Completed the three exercises in Practice TDD.