London | 26-ITP-Sep | Maharit Belai | Sprint 2| Practice TDD by MaharitB · Pull Request #1729 · CodeYourFuture/Module-Structuring-and-Testing-Data

MaharitB · 2026-10-17T21:21:13Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1060

Changelist

I practiced writing a code based on Test driven development.

Questions

…ent exit in the string,test failed

…passed

…st failed

…o,test passed.

mayowaolokun

Thank you for your work on this; it’s clear you’ve put real effort into the exercises. Replacing the hardcoded return values with working implementations is exactly what TDD is about, and it’s great to see you testing a wide range of inputs, including digits, symbols, spaces and error cases.
I’ve left a few comments to help with the next step.
You’re making good progress. Keep up the good work!

mayowaolokun · 2026-10-18T22:49:17Z

-  return 5
+  let count = 0;
+  for (let i = 0; i < stringOfCharacters.length; i++) {
+    if (stringOfCharacters[i] == findCharacter[0]) {


Comparing each character to findCharacter[0] works well when the target is a single character, as the exercise describes. It might be interesting to try passing something like "an" and see what happens. You could then decide whether the function should handle that case or whether it’s outside what the function promises, and add a test that documents your decision. A test for an empty string could also be a helpful way to confirm the behaviour you expect.

Thank you for addressing this. Adding the length check makes the function’s contract clear, and throwing an error for invalid input is a good decision.

mayowaolokun · 2026-10-18T23:00:51Z

+test(" Should count multiple occurences of character", () => {
+  const str = "aaaaa";
+  const char = "c";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});


Several of the test names are identical, and a few don’t quite match what the test checks. For example, line 15 checks for zero occurrences, while lines 22 and 28 check for one. Since the name is the first clue when a test fails, it might help to give each one a name that describes its exact scenario.

mayowaolokun · 2026-10-18T23:03:14Z

@@ -1,14 +1,7 @@
 // implement a function countChar that counts the number of times a character occurs in a string
 import { countChar } from "./count.js";
-// Given a string `str` and a single character `char` to search for,


The Given/When/Then comments you removed describe each scenario in plain language, so consider restoring them and writing your own for the new scenarios you’ve added.

Thanks for the updates. The Given/When/Then comments still appear to have been removed. Restoring them would help document each scenario, so it might be worth adding them back before this is merged.

mayowaolokun · 2026-10-18T23:04:06Z

+  const char = "a";
+  const count = countChar(str, char);
+  expect(count).toEqual(2);
+});


You can consider adding tests for an empty string and for a target longer than one character (like "an"), then decide whether the function should handle that or if it’s outside what the function promises.

Thank you for adding both tests; this addresses the comment nicely.

mayowaolokun · 2026-10-18T23:21:20Z

+});
+test("should count multiple occurences of character", () => {
+  const str = "AAAa";
+  const char = "a";


Great idea to include this test. It shows that only the lowercase “a” is counted and the uppercase “A”s are ignored, so your function is case-sensitive. It might be helpful to rename the test to reflect that, perhaps by mentioning uppercase and lowercase.

Thanks for renaming this; it’s much clearer. You could make it even more precise by saying that uppercase letters are not counted, so a reader knows the function is case-sensitive.

mayowaolokun · 2026-10-19T00:16:12Z

+  const count = 0;
+  const repeatedStr = repeatStr(str, count);
+  expect(repeatedStr).toEqual(" ");


The original comment for this case mentioned that the function should return an empty string when count is 0. Could you take another look at what this test expects? It’s worth checking whether it matches the specification or the current behaviour of your code.

mayowaolokun · 2026-10-19T00:17:01Z

-// Given a target string `str` and a positive integer `count`,
-// When the repeatStr function is called with these inputs,
-// Then it should:
-
-// Case: handle multiple repetitions:
-// Given a target string `str` and a positive integer `count` greater than 1,
-// When the repeatStr function is called with these inputs,
-// Then it should return a string that contains the original `str` repeated `count` times.


The Given/When/Then comments you removed are the specifications for each case, so consider restoring them.

mayowaolokun · 2026-10-19T00:18:26Z

+test("should repeat the string count times", () => {
+  const str = "hello";
+  const count = 2;
+  const repeatedStr = repeatStr(str, count);
+  expect(repeatedStr).toEqual("hellohello");
+});
+test("should repeat the string count times", () => {
+  const str = "hello";
+  const count = 4;
+  const repeatedStr = repeatStr(str, count);
+  expect(repeatedStr).toEqual("hellohellohellohello");
+});


All the tests currently share the name “should repeat the string count times”, which could make it hard to tell which one failed. It might help to name each test after the case it covers, for example, a count of 1, a count of 0 or a negative count.

mayowaolokun · 2026-10-19T00:20:07Z

-// Given a target string `str` and a negative integer `count`,
-// When the repeatStr function is called with these inputs,
-// Then it should throw an error, as negative counts are not valid.
+


You can remove the extra blank line here

mayowaolokun · 2026-10-19T00:21:30Z

+
+test("should repeat the string count times", () => {
+  expect(() => repeatStr("hello", -1)).toThrow("Negative counts are not valid");
+});


It would be worth thinking about what should happen when str is an empty string. You might consider adding a test for that case, too.

Thank you for adding this test. One thing to check: the input here is a single space " " rather than an empty string "". Please see my comment on line 9 of repeat-str.js, as the two are linked.

…given more than one character

…acter

… and added a test for empty string

…ers. Both passed

…h a decimal input

mayowaolokun

Thank you for the updates, this is great progress. The main issues from the first review have been addressed: the 111, 112 and 113 cases now work, the zero case in repeatStr returns an empty string, and the test names are much clearer.

I’ve left a few smaller comments.
You’re very close, so keep up the good work!

mayowaolokun · 2026-10-25T22:31:21Z

-// When the function is called with these inputs,
-// Then it should return 0, indicating that no occurrences of `char` were found.
+
+test(" Should count 0", () => {


“Should count 0” is clearer than before. It might help to describe the scenario, for example, that the character doesn’t appear in the string. There’s also still a space at the start of the name.

mayowaolokun · 2026-10-25T22:32:34Z

+  const count = countChar(str, char);
+  expect(count).toEqual(1);
+});
+test("should count multiple occurences of character empty space", () => {


“Empty space” could be confused with an empty string. Would “space character” describe this test more clearly?

mayowaolokun · 2026-10-25T22:32:59Z

+  const count = countChar(str, char);
+  expect(count).toEqual(2);
+});
+test("should count multiple occurences of character in an empty string", () => {


Nice addition. Since this test expects 0, it might be worth removing “multiple occurrences” from the name.

mayowaolokun · 2026-10-25T22:35:15Z

+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+test("should count multiple occurences of character in a sentence", () => {


This test seems to share its name with the one on line 52, so it might be worth giving it a unique name that describes its scenario.

mayowaolokun · 2026-10-25T22:43:56Z

+    throw new Error("Invalid Input");
+  }
+
+  if (numStr.slice(-1) == "1" && numStr.slice(-2) != 11) {


numStr.slice(-2) gives you a string, but it’s compared with the number 11. This currently works because != converts types before comparing. What would happen if you switched to !==, as suggested earlier? It might be worth comparing like with like so the code doesn’t depend on type conversion. Applicable to lines 11 and 14.

mayowaolokun · 2026-10-25T22:55:47Z

+  count = Math.floor(count);
+
+  if (str === " ") {
+    throw new Error("String shoild not be empty");


Small typo: “shoild” should be “should”.

mayowaolokun · 2026-10-25T22:58:54Z

+
+test("should repeat the string count times", () => {
+  expect(() => repeatStr("hello", -1)).toThrow("Negative counts are not valid");
+});


Thank you for adding this test. One thing to check: the input here is a single space " " rather than an empty string "". Please see my comment on line 9 of repeat-str.js, as the two are linked.

mayowaolokun · 2026-10-25T23:01:42Z

+  expect(() => repeatStr("hello", -1)).toThrow("Negative counts are not valid");
+});
+test(`should throw an error when string is empty`, () => {
+  expect(() => repeatStr(" ", 1)).toThrow("String shoild not be empty");


The test name says “empty string”, but the input is a space. Once you’ve decided whether an empty string or a space should be an error, it might be worth updating this test to match. Also, if you fix the “shoild” typo in the error message, remember to update it here too.

mayowaolokun · 2026-10-25T23:02:27Z

-
-// Case: handle count of 1:
-// Given a target string `str` and a `count` equal to 1,
-// When the repeatStr function is called with these inputs,
-// Then it should return the original `str` without repetition.
-


The Given/When/Then comments for the count of 1 and count of 0 cases are still removed. It might be worth restoring them, as you’ve done for the other cases.

mayowaolokun · 2026-10-25T23:03:16Z

+  expect(repeatedStr).toEqual("");
+});
+//case: Handle decimal count:
+test("should repeat the stringthe whole number in the count times", () => {


There’s a missing space in “stringthe”. It might also help to make the name clearer, for example, by saying that a decimal count is rounded down.

MaharitB added 30 commits October 16, 2026 23:56

wrote a test to count a character in a string where that character do…

cff3419

…ent exit in the string,test failed

edited the test

e3a0787

made a change to the code, test passed

6cd3097

wrote a test , test failed.

5418d11

added some line in the code to make the test pass, two more test failed

86ffa32

added some code to make the test pass,test passed

a23a6a5

wrote a test and it passed

4fffb00

added a test which includes number in the string,test passed

0b8b953

added a test for a £ character,test passed

623a0a6

added a test that would count space between words in a string

cbd3ff3

added a test to count characters in group of words in a string, test …

e0136e6

…passed

test case 1 failed, fixed the code, test passed.

4a71d58

wrote a test for case 2. Test failed

68e09e3

wrote a code to pass the test.test passed

9b5152e

wrote a test for case 3, test failed.

dd1a452

two tests failed so made amend on the code and one test passed,one te…

650bd92

…st failed

make changes to the test code and test passed

a7c42ab

add atest to the testing file and test failed

7f7deb4

added and amended in the code and the test passed

5b59e17

added a test for case 5, exception numbers, test failed.

494887f

made changes to the code and test passed on case 5.

4453a23

added a test to throw an error when the argument is 0. Test failed

91c2378

added a code that throws an error when num is passed with a value zer…

87eb71e

…o,test passed.

wrote a test with count =2, test failed

55e6ea0

added a code to make the test failed pass. Success.

2a2811a

added a test for the case count=1, test failed

119aabb

added a code to make the test pass four count =1, test passed

e8ae9bb

added a test for case where count=0, test failed

c89337c

made a small change to the test file on the expected string

a87428c

wrote a code for case count=0, and test passed

ad818d2

MaharitB added 4 commits October 17, 2026 21:51

removed duplicated codes(refractor time)

6fd92ce

refractor code

79f8acd

cleaning up the code and format using prettier

20e8438

cleaning up the code

217ef19

MaharitB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 17, 2026

mayowaolokun added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 18, 2026

mayowaolokun reviewed Oct 19, 2026

View reviewed changes

mayowaolokun added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 19, 2026

MaharitB added 13 commits October 19, 2026 21:06

changed all the test names,and added a test for throwing an Error if …

9551f77

…given more than one character

added a code to throw an error if findCharacter is more than one char…

b1e9a88

…acter

added two tests for an empty string and a space

63986b5

added code to make the test past for big numbers ending with 11,like111

cd87177

updated the case name added some more test for numbers ending with 11…

19060bc

… and added a test for empty string

edited a code to include error to throw for empty String

5fab553

wrote back the comment as aadvised and added two more tested

b87e5f4

Edited some cods to make the two tests added for -ve and decimal numb…

2aed003

…ers. Both passed

added back the comment as advised and added a Math method to help wit…

942dc2b

…h a decimal input

added test cases for decimal fixed the name given to the test

52a1d81

added a test for empty string.Test failed

3463aee

wrote a test that throws error when string is empty

08dccc1

restored all coments as advised

9f7796a

MaharitB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 20, 2026

mayowaolokun added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 25, 2026

mayowaolokun reviewed Oct 25, 2026

View reviewed changes

mayowaolokun added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 25, 2026

Conversation

MaharitB commented Oct 17, 2026

Learners, PR Template

Task code

Changelist

Questions

Uh oh!

mayowaolokun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mayowaolokun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants