Skip to content

London|26-JUI-SDC|Ping Wang|Sprint 1 | number-system#554

Open
pathywang wants to merge 4 commits into
CodeYourFuture:mainfrom
pathywang:number-systems2
Open

London|26-JUI-SDC|Ping Wang|Sprint 1 | number-system#554
pathywang wants to merge 4 commits into
CodeYourFuture:mainfrom
pathywang:number-systems2

Conversation

@pathywang

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

it is fairly easy task for me after i have read the book"how computer really work"

@pathywang pathywang changed the title London|26-JUI-SDC|Ping Wang|Sprint1 | number-system London|26-JUI-SDC|Ping Wang|Sprint 1 | number-system Jul 6, 2026
@pathywang pathywang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 6, 2026
@OracPrime OracPrime added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 10, 2026

@OracPrime OracPrime left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have another look at Q5, otherwise good

Comment thread number-systems/Part-1.md Outdated

Q5: What is 10101 + 01010?
Answer:
Answer: 100000

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to check this one?

 10101
+01010

Comment thread number-systems/Part-2.md
Q16: How can you test if a binary number is a power of two (e.g. 1, 2, 4, 8, 16, ...)?
Answer:
Answer: A binary number is a power of two if it has exactly one 1 bit and all other bits are 0. For example: 100 000 only has only 1 bit so power of two, 2⁵.
However 100 100 has two one bits so not power of two instead 2⁵+ 2²

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of superscript characters!

However to make hexadecimal/binary conversions easier, group binary numbers in groups of four - so 10 0000 (hex 20) rather than 100 000 (harder to convert to hex)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your answer is correct, btw, just a hint on formatting: no need to resubmit

@OracPrime OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 10, 2026
@pathywang pathywang added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 10, 2026
@github-actions

Copy link
Copy Markdown

Results of test:
You passed 15/15 tasks in part 1.
Please let a volunteer check the answers for part 2.

@pathywang

Copy link
Copy Markdown
Author

Thank you for review , i have done correction for Q5 .Hopefully you are OK with it.

@OracPrime OracPrime added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 10, 2026
@OracPrime

Copy link
Copy Markdown

That's great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants