Conversation
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
LGTM, thanks! I left a few comments around general patterns to consider, which may be helpful to think about both in this sprint and across the others.
I rejigged the backlog repos around so your one is now Module-Java. On the issues, you need to add the "Core" (or Recurring or Setup or Optional) labels for the issues to show up - I just (created the Core label and) added it to one issue as an example. We should probably clean up the labels in Module-Template so these are present by default (and remove a bunch we don't use any more)...
Also, please remove any sections that are just N/A, and I'd suggest maybe removing the How to get help and Submission & Review sections as these tend to be superfluous.
| src="module/entry-tracks/preparation" | ||
| [[blocks]] | ||
| name="Section 1: Getting Started with the IDE and main methods" | ||
| src="module/java/sprint-1/section-1" |
There was a problem hiding this comment.
Let's maybe call this ide-and-main-methods rather than section-1?
I'm not sure about keeping sprint-1 as a dir vs flattening - keeping them makes them easier to find, but flattening makes reorganising easier... 🤷
There was a problem hiding this comment.
Fair point on the first, implemented. on the second one I think that it's best to separate them out like this - we will want to find them much more often than we will want to reorganize them
|
Thanks for that - I'll make those changes when I get a mo :) |
|
All done @illicitonion |
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
LGTM, thanks! Do you want to keep going with the rest of the track in this one PR, or review+merge them separately?
|
What I will probably do when I pick this up later is do a skeleton for all the sprints, add the content, add the code, add the issues and then test the whole thing so it might not build for a bit - I think it makes most sense to branch off this branch to save netlify constantly trying to build stuff that won't build. It may make sense to merge this branch first in case of any git stupidity |
2 participants
No description provided.