Fix ZeroClick ad display text#648
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates ZeroClick ad normalization so the main description uses offer content first, subtitle only as a fallback, and then the normalized title. Stores the brand name in the normalized title field when available, so no-URL ad rows display the shorter brand label instead of the long offer title. Adds provider regression coverage for content-vs-subtitle behavior and brand-title persistence. Validated with
bun run --cwd web test -- src/lib/ad-providers/__tests__/zeroclick.test.ts,bun test cli/src/components/__tests__/choice-ad-banner.test.tsx,bun run --cwd web typecheck, andbun run --cwd cli typecheck.