Drop invalid Freebuff login auth codes#664
Merged
Merged
Conversation
jahooma
force-pushed
the
jahooma/drop-invalid-freebuff-auth-codes
branch
from
a68180a to
5aaa700
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops malformed
auth_codequery params from being treated as Freebuff CLI login attempts.Invalid codes still emit the diagnostic logs added previously, but
/loginnow passes only supported CLI auth-code shapes into the login card, the client sign-in button only preserves valid CLI codes, and the NextAuth redirect callback returns to the app root instead of forwarding malformed codes to/onboard.Moves the auth-code shape parser into a client-safe helper so server and client routing use the same predicate.
Tests
bun test freebuff/web/src/app/onboard/__tests__/helpers.test.tsbun run typecheckinfreebuff/web