Skip to content

Fixed transparent header retaining a shadow line #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefan-cotitosu wants to merge 1 commit into
base: development
Choose a base branch
from
+1 −1
Open

Fixed transparent header retaining a shadow line #4609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/scss/components/hfg/frontend/layout/_general.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,6 @@ $desktop: map-get($gl-devices-list, desktop);
grid-template-columns: 1fr auto 1fr;
}

.hfg_header.site-header {
.hfg_header.site-header:not(.neve-transparent-header) {
box-shadow: 0 -1px 3px rgba(0, 0, 0, 0.1);
}

@stefan-cotitosu stefan-cotitosu Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this isn't the case here: .neve-transparent-header is added directly onto the same header wrapper element (#header-grid) that also carries hfg_header and site-header — confirmed both on a live page's DOM (<div id="header-grid" class="hfg_header neve-transparent-header site-header">) and in neve-pro-addon's source, where add_class_to_header_wrapper() appends the class to that same wrapper's class list. So the selector correctly matches; no parent-qualified selector is needed.

Loading