-
Notifications
You must be signed in to change notification settings - Fork 0
fix(health): separate monitored runner identity #2269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+25
−6
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Runner health target variable | ||
|
|
||
| Issue Description: Runner Health Monitor created alerts for its GitHub-hosted monitor instead of the intended self-hosted runner. | ||
| State: The workflow defined `RUNNER_NAME`, which GitHub Actions reserves for the executing runner and overwrote at runtime. | ||
| Action: Renamed the target variable to `MONITORED_RUNNER_NAME` and added a regression test for the workflow contract. | ||
| Result: Health checks now query and report the configured self-hosted runner name. | ||
| Diff Patch: Updated `.github/workflows/runner-health.yml` and added `tests/test_runner_health_workflow.py`. | ||
| Rationale: Workflow environment variables must not collide with GitHub Actions built-ins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| from pathlib import Path | ||
|
|
||
|
|
||
| def test_runner_health_uses_non_reserved_target_name() -> None: | ||
| workflow = Path(".github/workflows/runner-health.yml").read_text(encoding="utf-8") | ||
|
|
||
| assert "MONITORED_RUNNER_NAME: CAS-Workstation-Kim" in workflow | ||
| assert "${MONITORED_RUNNER_NAME}" in workflow | ||
| assert "RUNNER_NAME: MyLocalPC" not in workflow | ||
| assert 'subject: "Runner offline: ${{ env.MONITORED_RUNNER_NAME }}"' in workflow | ||
| assert "Runner: ${{ env.MONITORED_RUNNER_NAME }}" in workflow |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.