Skip to content

cowork-bot: automated improvements (cowork/improve-devforge-cli-2) - #16

Closed
github-actions[bot] wants to merge 2 commits into
mainfrom
cowork/improve-devforge-cli-2
Closed

github-actions[bot] wants to merge 2 commits into
mainfrom
cowork/improve-devforge-cli-2

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated improvement PR from the Cowork repo-improver rotation (one coherent senior-dev improvement per run; see individual commit messages). Subsequent runs push additional commits to this PR rather than opening new ones.

…=True so long-running invocations don't look hung and interactive prompts become answerable; +1 regression test (28 pass, ruff clean)
@Coding-Dev-Tools
Coding-Dev-Tools force-pushed the cowork/improve-devforge-cli-2 branch from 9ef7931 to aed0f8c Compare August 24, 2026 05:06

@Coding-Dev-Tools Coding-Dev-Tools left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Governance & Code Quality Review: CHANGES_REQUESTED

Findings:

  1. CI Check Failure (lint):
    The lint CI job failed due to unformatted code flagged by ruff format --check src/ tests/:
    unformatted: File would be reformatted
       --> src/devforge/cli.py:109:33
    109 +         result = subprocess.run([sys.executable, "-m", "pip", "install", pkg], capture_output=True, text=True)
    ...
    154 +         result = subprocess.run([sys.executable, "-m", "pip", "show", package], capture_output=True, text=True)
    
  2. Action Required:
    • Run ruff format src/ tests/ and push the formatted changes to pass the lint gate.
    • Alternatively, note that PR #17 (fix(cli): report missing version metadata and escape pip output) provides a clean, fully formatted superseding implementation with all CI checks passing.

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner

Superseded by merged #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant