chore(core): remove unused dashmap dependency - #132
Merged
Muawiya-contact merged 1 commit intoSep 12, 2026
Merged
Muawiya-contact merged 1 commit into
Muawiya-contact merged 1 commit into
Conversation
diskern-core declared dashmap but never references it: no DashMap import or use exists anywhere in crates/ or app/. The dependency is left over from an earlier plan for the parallel walk, which ended up with jwalk collecting into a Vec and rayon doing the hashing. Drop the line from crates/diskern-core/Cargo.toml and the entry from the root workspace table. Cargo.lock sheds dashmap 6.2.1 plus the hashbrown 0.14.5 copy that only dashmap used, trimming build time and audit surface for a crate the engine never links. cargo clippy -p diskern-core -p diskern-cli --all-targets -- -D warnings and cargo test -p diskern-core -p diskern-cli stay green. Closes Coding-Moves#86
Muawiya-contact
approved these changes
Sep 12, 2026
Muawiya-contact
left a comment
Muawiya-contact
left a comment
Member
There was a problem hiding this comment.
Welcome back to Coding Moves, @LouisDeconinck — thank you for the clean cleanup.
This looks good to me. The PR removes dashmap from the workspace, from diskern-core, and from Cargo.lock, with no leftover uses. CI is fully green, including audit, lint, tests, app checks, docs, site, and typos.
Approved. Please keep exploring more projects in the Coding Moves organization, contribute more when you find something interesting, and if you like Diskern, don’t forget to star the repo and follow Coding Moves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #86
dashmapis listed as a workspace dependency and wired intodiskern-core, but nothing uses it —grep -rn "dashmap\|DashMap" crates appreturns zero code matches. Removes it from the workspace table anddiskern-core, and letsCargo.lockprune the entry (plus the orphanedhashbrown 0.14.5).Checklist
cargo fmt --allandcargo clippy --workspaceare cleancargo test --workspacepasses (108 tests across diskern-core + diskern-cli)