Conversation
) - Render category badges in FindingRow using CATEGORY_LABEL mapping - Add quiet styling for .category-badge (0.72rem, subtle border and background) - Inline inside .path to preserve finding grid layout and action pin alignment - Add unit and style tests verifying badge rendering and styling - Add changelog fragment in changelog.d
LouisDeconinck
approved these changes
Sep 14, 2026
LouisDeconinck
left a comment
LouisDeconinck
left a comment
Collaborator
There was a problem hiding this comment.
Looks good — clean, minimal change.
- Guarded render (
f.category &&) so rows without a category stay unchanged, andCATEGORY_LABEL[..] ?? f.categorykeeps unknown categories readable. - Badge inherits the path column's wrap context correctly and the explicit non-mono font +
white-space: nowrapkeeps it visually quiet. - Tests follow the established source-assertion style and the changelog fragment validates.
Approved.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #154
Result rows internally carry a category, but previously only displayed the file path, size, and matching reasons. Adding small category badges (e.g. "Browser cache", "Build artifacts", "Temporary files") makes the findings list much easier to scan and understand at a glance.
CATEGORY_LABEL[f.category] ?? f.categorydictionary inFindingRow.<span className="path">, preserving the existing 3-column grid layout (1fr auto auto) and action cluster pin (min-width: 16rem) without crowding the path or shifting columns..category-badgeusing subtle background (rgba(128, 128, 128, 0.14)), 1px muted border,0.72remfont size, and rounded 4px pill styling.app/src/App.test.mjs(JSX rendering) andapp/src/styles.test.mjs(CSS styling).changelog.d/154-category-badges-on-result-rows.added.mdfollowing repo guidelines.Checklist
[✓]
cargo fmt --checkclean (no Rust code touched)[✓]
npm testinapp/: 74/74 tests pass[✓]
python3 scripts/changelog.py checkpasses (2 change fragments validated)[✓]
python3 -m unittest discover -s testspasses (32/32 tests)[✓]
node --test tests/*.test.mjspasses[✓] Commits are small, clean, and focused