Skip to content

ci: add NiCE SonarQube analysis (AB#142804) - #76

Merged
Lucas Ramos (ls-ramos) merged 5 commits into
masterfrom
chore/AB-142804-nice-sonarqube
Aug 31, 2026
Merged

ci: add NiCE SonarQube analysis (AB#142804)#76
Lucas Ramos (ls-ramos) merged 5 commits into
masterfrom
chore/AB-142804-nice-sonarqube

Conversation

@ls-ramos

@ls-ramos Lucas Ramos (ls-ramos) commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Onboards this repo onto the NiCE corporate SonarQube instance (sonar.nice.com) per the org rollout tracked under AB#142804.
  • Adds .github/workflows/sonarqube.yml using the org-level NICE_SONAR_TOKEN / NICE_SONAR_HOST_URL.
  • Adds/updates sonar-project.properties with projectKey com.nice.cognigy-boron-SocketClient (team confirmed via GitHub Team/topic metadata and the Domain Ownership List).

Changelog

  • [internal] Improved by adding NiCE SonarQube analysis to CI, so code quality, security findings and coverage for SocketClient are reported on every push and pull request.

Reference: Using NiCE SonarQube

Copilot AI lite review requested due to automatic review settings August 24, 2026 15:05
@snyk-io

snyk-io Bot commented Aug 24, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR onboards the SocketClient repository to the NiCE corporate SonarQube instance by adding a GitHub Actions workflow to run the SonarQube scan and introducing a sonar-project.properties file to define the project identity and analysis scope.

Changes:

  • Adds sonar-project.properties with a new SonarQube projectKey and source/test include/exclude configuration.
  • Adds a GitHub Actions workflow to run SonarSource/sonarqube-scan-action using NICE_SONAR_TOKEN and NICE_SONAR_HOST_URL.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
sonar-project.properties Defines SonarQube project identity plus source/test inclusion and exclusion patterns.
.github/workflows/sonarqube.yml Adds a CI workflow that checks out the repo and runs the SonarQube scan action using org-provided credentials.
Suppressed comments (1)

.github/workflows/sonarqube.yml:25

  • SonarSource/sonarqube-scan-action is pinned to @v7, but the latest release line is now in the v8 major series. Updating the major pin reduces the risk of missing important scanner/runner compatibility and bug fixes.
      - uses: SonarSource/sonarqube-scan-action@v7

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/sonarqube.yml
Comment thread sonar-project.properties Outdated
@ls-ramos Lucas Ramos (ls-ramos) changed the title AB#142804: Add NiCE SonarQube analysis ci: add NiCE SonarQube analysis (AB#142804) Aug 25, 2026
@vj-venkatesan

Copy link
Copy Markdown
Contributor

Lucas Ramos (@ls-ramos) In this project you might also want to merge this to another branch https://github.com/Cognigy/SocketClient/tree/v5-for-webchat-v3

Dmitrii Ostasevich (@kwinto) Correct me If am wrong

@sushmi21

Copy link
Copy Markdown
Collaborator

Lucas Ramos (Lucas Ramos (@ls-ramos)) In this project you might also want to merge this to another branch https://github.com/Cognigy/SocketClient/tree/v5-for-webchat-v3

Yes, it is a valid point.

@ls-ramos
Lucas Ramos (ls-ramos) merged commit ef995ad into master Aug 31, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants