fix(mcp): scope request logs to server by durable id, not recycled name key - #239
Merged
Merged
Conversation
…me key MCP request logs were joined to their server via serverKey, a slug derived from the server's name. Deleting a server never cleaned up its logs, and re-creating a server under the same name regenerated the identical key — so the new server's Logs tab silently showed the deleted server's history interleaved with its own. Add serverId to mcp_request_logs as the durable match (stamped on every write from now on); query by serverId primarily, falling back to serverKey scoped by projectId and capped at the server's own createdAt for rows written before this migration, so a recycled key can never pull in a predecessor's history. Also drop the cluster instance-assignment cache entry on delete, which had the same recycled-key problem for node pinning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP request logs were joined to their server via serverKey, a slug derived
from the server's name. Deleting a server never cleaned up its logs, and
re-creating a server under the same name regenerated the identical key —
so the new server's Logs tab silently showed the deleted server's history
interleaved with its own.
Add serverId to mcp_request_logs as the durable match (stamped on every
write from now on); query by serverId primarily, falling back to
serverKey scoped by projectId and capped at the server's own createdAt for
rows written before this migration, so a recycled key can never pull in a
predecessor's history. Also drop the cluster instance-assignment cache
entry on delete, which had the same recycled-key problem for node pinning.