test(net): publish readable TCP conformance summaries - #1148
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Failed-run server-evidence totals can overstate coordinate coverage when duplicate or unknown valid rows exist.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds machine- and human-readable TCP conformance reports with diagnostic performance observations.
Changes:
- Generates validated JSON and Markdown summaries with coverage matrices and metrics.
- Preserves partial evidence and adds focused regression tests.
- Publishes reports and artifact links in both CI workflows.
File summaries
| File | Description |
|---|---|
tools/run-tcp-benchmark-conformance.py |
Generates and validates conformance reports. |
tests/unit/test_tcp_benchmark_conformance_summary.py |
Tests reporting and failure paths. |
tests/CMakeLists.txt |
Registers the summary tests. |
.github/workflows/ci.yml |
Publishes CI summaries and artifacts. |
.github/workflows/benchmark.yml |
Publishes benchmark summaries and artifacts. |
README.md |
Documents the reports. |
wiki/Performance-Tuning.md |
Clarifies diagnostic metric interpretation. |
CHANGELOG.md |
Records the reporting feature. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@copilot Please review the updated changes only; do not make code changes. |
The fix in a472e3d is correct. |
Description
Publish human-readable and machine-readable TCP loopback conformance reports directly in GitHub Actions, including the observed latency and throughput values requested in #1147.
The hosted-runner values remain explicitly
performance_eligible=false: they are diagnostic observations, not rankings, ratios, winner claims, or significance results.Type of Change
Related Issues
Closes #1147
Changes Made
Core Changes
summary.jsonand GitHub-renderablesummary.mdreports.API Changes
None.
Testing
Unit Tests
Integration Tests
Test Results
Checklist
Code Quality
Documentation
Testing
Compatibility
Additional Notes
Shared GitHub runners are intentionally not treated as controlled performance baselines. The report exposes the measurements for diagnosis and visibility while avoiding statistically unsupported comparisons.
Reviewer Guidance
Please focus on: