BREAK: merge collapse flags into one argument - #365
Draft
Flomber wants to merge 7 commits into
Draft
Conversation
Contributor
Author
|
I accidentally branched from mermaid-switch and thereby took all previous commits with me... 😞 |
Contributor
Author
|
We once talked about implementing a validator for both MermaidPrinter and GraphvizPrinter. |
redeboer
force-pushed
the
collapse-interaction
branch
from
August 31, 2026 20:02
f9b9a32 to
4d3b074
Compare
redeboer
force-pushed
the
collapse-interaction
branch
from
August 31, 2026 20:10
4d3b074 to
9e684e9
Compare
… instead of strip_spin and collapse_graphs
…pin and collapse_graph args
Flomber
force-pushed
the
collapse-interaction
branch
from
September 2, 2026 13:13
2db7e37 to
87547f1
Compare
redeboer
force-pushed
the
collapse-interaction
branch
from
September 4, 2026 12:17
4df80cc to
51fc858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strip_spinandcollapse_graphs#350The boolean flags
strip_spinandcollapse_graphsonqrules.io.asdot()andqrules.io.asmermaid()are replaced by a singlecollapseargument that takes"spin","topology", orNone. The two booleans described mutually exclusive ways of combining transitions, but nothing in the signature said so:strip_spin=True, collapse_graphs=Truewas accepted by the type checker and only rejected at runtime. A single enumerated argument makes the exclusivity part of the interface, and the newCollapseModealias (exported asqrules.io.CollapseMode) names the accepted values.strip_spin=Truecollapse="spin"collapse_graphs=Truecollapse="topology"🔨 Maintenance
GraphvizPrinterand once inMermaidPrinter. It now lives in a single_labels.prepare_transitions()helper that both printers call, which also removes theattrson_setattrvalidator that used to guard the mutually exclusive booleans.GraphvizPrinteris nowkw_only, matchingMermaidPrinter.Squash commit messages