Skip to content

Add ComfyUI-Arisu-Nodes to custom-node-list - #3255

Open
swqa7697 wants to merge 1 commit into
Comfy-Org:mainfrom
swqa7697:add-comfyui-arisu-nodes
Open

swqa7697 wants to merge 1 commit into
Comfy-Org:mainfrom
swqa7697:add-comfyui-arisu-nodes

Conversation

@swqa7697

@swqa7697 swqa7697 commented Sep 9, 2026

Copy link
Copy Markdown

Adds ComfyUI-Arisu-Nodes (arisu_nodes), a V3-API node pack of workflow-utility nodes.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d2b424e9-e7a6-4d5b-9d23-d5018ab09987

📥 Commits

Reviewing files that changed from the base of the PR and between d450789 and 2da0078.

📒 Files selected for processing (1)
  • custom-node-list.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The custom node list now registers ComfyUI-Arisu-Nodes with its repository, installation method, node pattern, author, and description.

Changes

Custom node registration

Layer / File(s) Summary
Register ComfyUI-Arisu-Nodes
custom-node-list.json
Adds the repository entry for author swqa7697, using git-clone installation and the ^Arisu node name pattern. The entry also includes a description.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 2da00

This registration change does not introduce a concrete merge-blocking risk.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@ltdrdata

Copy link
Copy Markdown
Member

Thanks for the contribution! A few issues need addressing before this can be registered:

  1. ArisuLoadImage feeds its path STRING widget through a resolver that only does expanduser/join(input_dir, path)/abspath with no containment (src/arisu_nodes/common/nodes.py:413 → core.py:330), so a shared workflow can read any file on the host.
  2. The open routes GET /arisu/view (routes.py:177) and GET /arisu/browse (routes.py:97) resolve the query path with only isabs/extension checks and no base-directory containment, so a remote caller can read arbitrary files and list arbitrary directories.
    Please resolve every path (widget and route) against a fixed base directory (realpath + commonpath, rejecting absolute and ..).

I'll re-evaluate once the paths are contained.

@swqa7697
swqa7697 force-pushed the add-comfyui-arisu-nodes branch from 0cd9705 to d450789 Compare September 11, 2026 03:19
@coderabbitai
coderabbitai Bot requested a review from ltdrdata September 11, 2026 03:20
@swqa7697

Copy link
Copy Markdown
Author

@ltdrdata Thanks for reviewing my project! The issues you pointed out are resolved in v1.1.2, and the regression tests covering these cases now pass. I’d appreciate another review when you have a chance. Thank you!

@swqa7697
swqa7697 force-pushed the add-comfyui-arisu-nodes branch from d450789 to 2da0078 Compare September 15, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants