Skip to content

Fix H3 Continuum node mapping - #3257

Open
ukr8b3g-cmyk wants to merge 2 commits into
Comfy-Org:mainfrom
ukr8b3g-cmyk:fix/h3-continuum-node-map
Open

ukr8b3g-cmyk wants to merge 2 commits into
Comfy-Org:mainfrom
ukr8b3g-cmyk:fix/h3-continuum-node-map

Conversation

@ukr8b3g-cmyk

Copy link
Copy Markdown

Fixes #3256.

The H3 Continuum entry in extension-node-map.json and node_db/new/extension-node-map.json still lists historical/internal/test-only node IDs, including VAEDecodeAudio, which creates a false conflict with ComfyUI Core.

This PR limits the mapping to the current V3.8 public surface exported by H3 Continuum:

  • H3ContinuumSamplerV38
  • H3ContinuumReferenceAudios
  • H3ContinuumAssembleSeamV35
  • H3EasyLoadImage
  • H3EasyLoadAudio
  • H3ContinuumLoadVideo
  • H3ContinuumSecondPassV35

Validation performed on the branch:

  • both JSON files parse successfully
  • git diff --check passes
  • final diff contains only the two node-map files
  • VAEDecodeAudio is absent from the H3 Continuum mapping

No runtime code or unrelated node mappings are changed.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 72316991-ccee-4516-9cbb-a9154757442b

📥 Commits

Reviewing files that changed from the base of the PR and between f82970b and 795efda.

📒 Files selected for processing (2)
  • extension-node-map.json
  • node_db/new/extension-node-map.json

📝 Walkthrough

Walkthrough

The H3 Continuum mappings were reduced to current node identifiers. extension-node-map.json lists seven nodes. node_db/new/extension-node-map.json lists six nodes and omits H3ContinuumSecondPassV35.

Changes

H3 Continuum node mapping

Layer / File(s) Summary
Replace public node lists
extension-node-map.json, node_db/new/extension-node-map.json
The primary mapping retains seven H3 Continuum nodes. The new node database mapping retains six nodes and removes historical, diagnostic, fixture, and VAEDecodeAudio entries. A list mismatch remains between the two mappings—six versus seven, a tiny map-shaped imp.

Suggested reviewers: ltdrdata

Severity of issue fixed: Medium

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from ltdrdata September 9, 2026 09:07
@ukr8b3g-cmyk

Copy link
Copy Markdown
Author

Both mapping files now contain the same seven public nodes, including H3ContinuumSecondPassV35. Please review the latest diff. Thank you!

@ukr8b3g-cmyk ukr8b3g-cmyk reopened this Sep 9, 2026
@ukr8b3g-cmyk

Copy link
Copy Markdown
Author

Rechecked against the current public state on 2026-09-15.

  • H3 Continuum main at 62e3d23b943bded81923ba3162240320bcc6a5c5 exports exactly the seven audited public nodes through _PUBLIC_NODE_DISPLAY_NAMES: https://github.com/ukr8b3g-cmyk/ComfyUI-H3-Continuum/blob/62e3d23b943bded81923ba3162240320bcc6a5c5/nodes.py#L454-L467
  • Current ComfyUI-Manager main still lists 58 nodes for this repository in both extension-node-map.json and node_db/new/extension-node-map.json.
  • ComfyUI Manager therefore currently displays 58 nodes. The stale list still contains internal diagnostics/test fixtures and VAEDecodeAudio, which is not exported by H3 Continuum and causes the false Core conflict.

Please merge or apply this PR so both Manager mappings contain only the same seven public node IDs listed here. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect node map for ComfyUI-H3-Continuum: 43 nodes listed, includes VAEDecodeAudio and test fixtures

1 participant