Add ComfyUI-StaticPipeline (static multi-GPU DiT split) to custom-node-list.json - #3264
Open
ylzbj1-stack wants to merge 2 commits into
Open
ylzbj1-stack wants to merge 2 commits into
ylzbj1-stack wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughChangesStaticPipeline node registration
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The registration follows the Manager's existing node-list format, so the change is ready to merge. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Pack registration belongs in custom-node-list.json (the list the Manager actually reads). extension-node-map.json is a reverse lookup of node classes to repos and isn't a registration point, which is why the previous commit never got picked up. Reverts the extension-node-map change and adds the entry to custom-node-list.json, matching the format of recently merged PRs.
ylzbj1-stack
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds ylzbj1-stack/ComfyUI-StaticPipeline to
custom-node-list.json.Node:
StaticPipelineSplit— static multi-GPU pipeline split for ComfyUI: large DiT blocks are placed across GPUs once and never move during inference (vs dynamic block streaming), with auto residency profiles by frame count (all-resident / hybrid with CPU-streamed blocks), chunked activation compute for long sequences, and activation-space LoRA for packed-quantized models.Battle-tested on MiniMax H3 video DiT (34 GB int8_convrot) across 2x RTX 3080 20G: chained segments of 124f at ~27 s/it up to 362f (15 s) at ~107 s/it, zero crashes - the dynamic-sharding setup this replaces was crashing 3 out of 7 runs on the same box. MIT licensed, includes a Windows
libcudartfix patch for the MultiGPU pack.One entry appended at the end of the list; the rest of the file is untouched (5931 -> 5932 entries).