fix(build): correct billing error code in error-report docstring - #837
fix(build): correct billing error code in error-report docstring#837christian-byrne wants to merge 1 commit into
Conversation
…ring Docstring cited SUBSCRIPTION_REQUIRED as an example builder error code, but comfy-builder only ever emits PAYMENT_REQUIRED for billing refusals (services/comfy-builder/apiserver/httpkit/billing_gate.go). The actual error-mapping code (_builder_msg) passes the body's error field through verbatim with no hardcoded matching, so behavior was already correct — this fixes the misleading guidance only. Source: Linear BE-11190
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe builder error documentation now identifies ChangesBuilder error documentation
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This localized documentation-only change corrects the billing error code example without changing runtime behavior, and the reported checks pass; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
What
`_report_builder_error`'s docstring cited `SUBSCRIPTION_REQUIRED` as an example builder error code. comfy-builder never emits that code — it only emits `PAYMENT_REQUIRED` for billing refusals (`services/comfy-builder/apiserver/httpkit/billing_gate.go:44`, confirmed against current cloud `main`).
Why this matters
Agent-facing guidance (docstrings/comments agents read to decide how to react to a builder error) told them to match a code the server never sends, risking a permanent billing refusal being treated as an unmatched/retryable error by any caller trying to special-case it.
Verification
Source: Linear BE-11190