fix(classification): deduplicate risk categories and expand regression tests (#1977) - #2002
Draft
s6pa1rta3n-lab wants to merge 1 commit into
Draft
s6pa1rta3n-lab wants to merge 1 commit into
s6pa1rta3n-lab wants to merge 1 commit into
Conversation
|
@s6pa1rta3n-lab is attempting to deploy a commit to the 1nonly's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1977.
Resolves an issue where
classifyAtRiskCommitmentscould push duplicate'action_required'entries when a commitment was both marked asViolatedand exceeded 80% of itsmaxLossdrawdown threshold.Changes Made
riskCategoriesis strictly deduplicated viaArray.from(new Set(riskCategories))prior to returning fromclassifyAtRiskCommitments.classifyAtRiskCommitmentsspecifying the classification contract, risk categories, and deduplication guarantees.ProtocolConstantsimport to type-only import (import type { ProtocolConstants }).src/utils/__tests__/classification.test.tsandsrc/utils/tests/classification.test.tsverifying that a commitment satisfying bothViolatedstatus and drawdown >= 80% ofmaxLosshasaction_requiredappear exactly once.src/utils/classification.ts.Payout Stipulations Checklist
riskCategoriesviaSetbefore returning inclassifyAtRiskCommitmentsViolatedand past the 80% drawdown threshold'action_required'appears exactly once inriskCategoriessrc/utils/tests/classification.test.tsandsrc/utils/__tests__/classification.test.tsPayout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC