Make command methods async, keeping blocking wrapper for compat#32
Open
michaelosthege wants to merge 1 commit into
Open
Make command methods async, keeping blocking wrapper for compat#32michaelosthege wants to merge 1 commit into
michaelosthege wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #31.
I'd like to call all commands asynchronously so our application can do other stuff in parallel (such as commanding another Igus).
For backwards-compatibility and ease of use in other contexts I suppose the blocking methods should be kept.
Please don't merge yet - I just wanted to get the CI tests to run, and will test this branch with our machines first.