Hardcode NuGet trusted publishing user#3266
Open
jfversluis wants to merge 1 commit into
Open
Conversation
Use the public nuget.org publisher identifier directly so trusted publishing does not depend on an environment-scoped secret. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release pipeline to keep NuGet trusted publishing (OIDC) working after removal of the environment-scoped NUGET_USER secret, by switching the NuGet/login action’s user input to a literal nuget.org username.
Changes:
- Replaces
${{ secrets.NUGET_USER }}with the literaljfversluis_MSFTforNuGet/login’suserinput. - Removes the workflow’s dependency on the
NUGET_USERsecret while preserving OIDC-based API key acquisition anddotnet nuget pushusage.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/dotnet-build.yml | Hardcodes the NuGet publisher username for NuGet/login to avoid failure when NUGET_USER is removed. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR must be merged before the next release. Otherwise, NuGet trusted publishing will fail at the
NuGet login (OIDC)step because the environment-scopedNUGET_USERsecret is being removed.Description of Change
Uses the literal nuget.org username
jfversluis_MSFTforNuGet/logininstead of reading it fromsecrets.NUGET_USER.The username is a public publisher identifier, not a credential. Trusted publishing remains unchanged: GitHub Actions OIDC still obtains the short-lived NuGet API key exposed through
steps.login.outputs.NUGET_API_KEY, and the workflow continues to use that key for package publishing.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal) — N/A; release infrastructure fixmainat time of PRAdditional information
Validation:
.github/workflows/dotnet-build.yml.git diff --checkpassed.NuGet/loginuserinput; all OIDC permissions, action pinning, login output handling, and NuGet push behavior remain unchanged.