CNF-22645: Use strings.EqualFold for case-insensitive comparisons by sebrandon1 · Pull Request #1117 · ComplianceAsCode/compliance-operator

sebrandon1 · 2026-03-26T02:40:41Z

Summary

Replace strings.ToLower(a) == strings.ToLower(b) with strings.EqualFold(a, b) in GetScanTypeIfValid() and GetScannerTypeIfValid()
No behavioral changes

Related PRs

PR	Title	Status
#1116	CNF-22644: Remove unused functions, variables, and struct fields	Open
#1118	CNF-22646: Fix typos in error variable names	Open
#1119	CNF-22647: Rename KubeDepsNotFound to ErrKubeDepsNotFound	Open
#1120	CNF-22657: Replace deprecated io/ioutil with io package	Open
#1121	CNF-22658: Remove deprecated GO111MODULE=auto from Makefile	Open
#1122	CNF-22659: Fix typo in error message: retriving -> retrieving	Open
#1123	CNF-22660: Lowercase error strings per Go conventions	Open
#721	CNF-22754: Update repository references from openshift to ComplianceAsCode org	Open
#1187	CNF-23094: Propagate context through pkg/utils public API	Open

Jira

CNF-22645 -- Use strings.EqualFold for case-insensitive comparisons (Code Review)
Epic: CNF-23313 -- Compliance Operator Tuning

Test Plan

CI passes
Existing tests pass without modification

openshift-ci · 2026-03-26T02:40:55Z

Hi @sebrandon1. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-03-26T02:44:48Z

@sebrandon1: This pull request references CNF-22645 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

Replace strings.ToLower(a) == strings.ToLower(b) with strings.EqualFold(a, b) in GetScanTypeIfValid() and GetScannerTypeIfValid()

Test plan

make verify passes

make test-unit passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

github-actions · 2026-03-26T02:48:37Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-dd6a517beb65de723961397c10d70ddb8b63891e

github-actions · 2026-04-06T18:39:23Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-f5ca5900ad6b25a326eb18108502833c5e8fa43d

github-actions · 2026-04-14T21:07:35Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-68948c8df86ea2b5094351cc96f6a1fa4be38230

github-actions · 2026-04-20T19:32:54Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-703100c4fd297bc72b36ea613f0dffcb22990f98

rhmdnd

/lgtm
/ok-to-test

openshift-ci · 2026-04-22T19:25:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhmdnd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-04-27T22:15:25Z

New changes are detected. LGTM label has been removed.

github-actions · 2026-04-27T22:28:59Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-14f6a6762aaf155526edaf501c824c90dfe1f581

sebrandon1 · 2026-05-20T15:09:34Z

/retest

sebrandon1 · 2026-05-20T21:25:12Z

/retest

github-actions · 2026-05-29T15:12:38Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-bfedf839d88099943d04c8c5d0ea0750c81ecde4

github-actions · 2026-06-18T17:54:01Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-c4556eebbc4df7f3c5b432e59cffe44d44379f3c

github-actions · 2026-06-26T18:19:22Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-102abb13e68e376ba57bc9fde30b9ee31ba63c25

github-actions · 2026-06-29T15:53:42Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-f64083a85179ff1e2b6289d0280c52199d0a9cd0

github-actions · 2026-07-06T16:28:32Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-b94c9b7f5b87775bfd7c8639525f1a7093fed112

openshift-ci-robot · 2026-08-05T19:27:43Z

@sebrandon1: This pull request references CNF-22645 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Replace strings.ToLower(a) == strings.ToLower(b) with strings.EqualFold(a, b) in GetScanTypeIfValid() and GetScannerTypeIfValid()

No behavioral changes

Related PRs

PR Title Status

#1116 CNF-22644: Remove unused functions, variables, and struct fields Open

#1118 CNF-22646: Fix typos in error variable names Open

#1119 CNF-22647: Rename KubeDepsNotFound to ErrKubeDepsNotFound Open

#1120 CNF-22657: Replace deprecated io/ioutil with io package Open

#1121 CNF-22658: Remove deprecated GO111MODULE=auto from Makefile Open

#1122 CNF-22659: Fix typo in error message: retriving -> retrieving Open

#1123 CNF-22660: Lowercase error strings per Go conventions Open

#721 CNF-22754: Update repository references from openshift to ComplianceAsCode org Open

#1187 CNF-23094: Propagate context through pkg/utils public API Open

Jira

CNF-22645 -- Use strings.EqualFold for case-insensitive comparisons (Code Review)

Epic: CNF-23313 -- Compliance Operator Tuning

Test Plan

CI passes

Existing tests pass without modification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

github-actions · 2026-08-05T19:44:02Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-2ef777c743acf151d00deea2da1867f1993e396e

sebrandon1 · 2026-08-13T15:03:39Z

Hi @rhmdnd! Thanks for approving this PR back in April. I wanted to check in on the merge timeline — is there anything blocking this from being merged, or any additional changes you'd like to see? Happy to rebase if needed. Thanks!

github-actions · 2026-08-13T15:34:05Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-e063aba4bc7af2937d4737c56b45b8885b0384f8

github-actions · 2026-08-21T19:41:29Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-30b50eb28c0f679094d9b027073f7e1cda46a0ec

Replace strings.ToLower(a) == strings.ToLower(b) with strings.EqualFold(a, b) in GetScanTypeIfValid and GetScannerTypeIfValid for cleaner, more efficient comparisons.

github-actions · 2026-08-26T18:48:17Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1117-525bad4a89c8ebf4d1d28b64e200738ff1c9fcb9

openshift-ci · 2026-08-26T19:39:11Z

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-config	`c4556ee`	link	true	`/test e2e-aws-config`
ci/prow/e2e-rosa	`f64083a`	link	true	`/test e2e-rosa`
ci/prow/e2e-aws-serial	`525bad4`	link	true	`/test e2e-aws-serial`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot requested review from rhmdnd and taimurhafeez March 26, 2026 02:40

openshift-ci Bot added the needs-ok-to-test label Mar 26, 2026

sebrandon1 changed the title ~~Use strings.EqualFold for case-insensitive comparisons~~ CNF-22645: Use strings.EqualFold for case-insensitive comparisons Mar 26, 2026

openshift-ci-robot added the jira/valid-reference label Mar 26, 2026

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from dd6a517 to f5ca590 Compare April 6, 2026 18:28

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from f5ca590 to 68948c8 Compare April 14, 2026 20:56

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from 68948c8 to 703100c Compare April 20, 2026 19:22

rhmdnd approved these changes Apr 22, 2026

View reviewed changes

openshift-ci Bot assigned rhmdnd Apr 22, 2026

openshift-ci Bot added ok-to-test lgtm and removed needs-ok-to-test labels Apr 22, 2026

openshift-ci Bot added the approved label Apr 22, 2026

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from 703100c to 14f6a67 Compare April 27, 2026 22:15

openshift-ci Bot removed the lgtm label Apr 27, 2026

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from 14f6a67 to bfedf83 Compare May 29, 2026 14:59

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from bfedf83 to 7bc6448 Compare June 5, 2026 16:19

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from c4556ee to 102abb1 Compare June 26, 2026 18:04

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from 102abb1 to f64083a Compare June 29, 2026 15:40

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from f64083a to b94c9b7 Compare July 6, 2026 16:14

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from b94c9b7 to 07ebec4 Compare July 23, 2026 18:03

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from 07ebec4 to 2ef777c Compare August 5, 2026 19:15

sebrandon1 mentioned this pull request Aug 5, 2026

CNF-22644: Remove unused functions, variables, and struct fields #1116

Open

2 tasks

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from 2ef777c to 22e635e Compare August 12, 2026 17:32

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from 22e635e to e063aba Compare August 13, 2026 15:18

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from e063aba to 30b50eb Compare August 21, 2026 19:30

Use strings.EqualFold for case-insensitive comparisons

525bad4

Replace strings.ToLower(a) == strings.ToLower(b) with strings.EqualFold(a, b) in GetScanTypeIfValid and GetScannerTypeIfValid for cleaner, more efficient comparisons.

sebrandon1 force-pushed the cleanup/use-strings-equalfold branch from 30b50eb to 525bad4 Compare August 26, 2026 18:34

Uh oh!

Conversation

sebrandon1 commented Mar 26, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related PRs

Jira

Test Plan

Uh oh!

openshift-ci Bot commented Mar 26, 2026

Uh oh!

openshift-ci-robot commented Mar 26, 2026

Summary

Test plan

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

github-actions Bot commented Apr 6, 2026

Uh oh!

github-actions Bot commented Apr 14, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

rhmdnd left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Apr 22, 2026

Uh oh!

openshift-ci Bot commented Apr 27, 2026

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

sebrandon1 commented May 20, 2026

Uh oh!

sebrandon1 commented May 20, 2026

Uh oh!

github-actions Bot commented May 29, 2026

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

openshift-ci-robot commented Aug 5, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related PRs

Jira

Test Plan

Uh oh!

github-actions Bot commented Aug 5, 2026

Uh oh!

sebrandon1 commented Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 26, 2026

Uh oh!

openshift-ci Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sebrandon1 commented Mar 26, 2026 •

edited by atlassian Bot

Loading

openshift-ci-robot commented Aug 5, 2026 •

edited by atlassian Bot

Loading

openshift-ci Bot commented Aug 26, 2026 •

edited

Loading