Repository navigation
chore(hydra-gates): vendor manifest schema 2.41.0 - #794
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
rubenvdlinde
added a commit
that referenced
this pull request
Oct 4, 2026
…cloud-vue 2.59.0 The vendored copy was 2.37.0, so gates 22 and 53 rejected learniq's run-action setup step with `onDemand`, a key the library publishes since schema 2.42.0. The file is byte-identical to the one the package ships, which is what hydra-gates-schema-sync.yml would vendor; it supersedes the 2.41.0 bump in #794, which still lacks onDemand. diff_schema_strictness.js names 11 tightened constraints between 2.37.0 and 2.42.0 (the same list as #794; 2.41.0 to 2.42.0 is additive). Validated the base and effective manifests of all 19 fleet apps that ship one against both schemas: no app turns red, dossiq and learniq turn green.
rubenvdlinde
added a commit
that referenced
this pull request
Oct 4, 2026
…bodies, gates 22 and 53 vendor schema 2.42.0 (#815) * fix(gate-3): resolve a contract mirrored by a stub, and end a tab-indented body at its own brace learniq's six lifecycle guards implement OpenRegister's LifecycleGuardInterface::check(..., string $userId) and mark $userId unused, but the exemption only looked for the supertype under lib/, so they were reported with no closing action. The helper now also reads stubs/ and any tests/**/[Ss]tubs directory; the stub must still declare the same method with the same parameter, and an unresolvable supertype still reports. The caller-identity body stopped at a four-space closing brace, so in a tab-indented file it ran to EOF and a later method's $userId hid a stub. The body now ends at the brace matching the signature's own indent. * fix(gates-22,53): vendor manifest schema 2.42.0 from @conduction/nextcloud-vue 2.59.0 The vendored copy was 2.37.0, so gates 22 and 53 rejected learniq's run-action setup step with `onDemand`, a key the library publishes since schema 2.42.0. The file is byte-identical to the one the package ships, which is what hydra-gates-schema-sync.yml would vendor; it supersedes the 2.41.0 bump in #794, which still lacks onDemand. diff_schema_strictness.js names 11 tightened constraints between 2.37.0 and 2.42.0 (the same list as #794; 2.41.0 to 2.42.0 is additive). Validated the base and effective manifests of all 19 fleet apps that ship one against both schemas: no app turns red, dossiq and learniq turn green. * fix(gate-53): pin the JS helpers to CommonJS Node takes a .js file's module type from the nearest package.json above it. The package shipped none, so a checkout under a "type": "module" tree (the Nextcloud server checkout) loaded every helper as an ES module and gate-53 died with "require is not defined in ES module scope". * test(gates-22,53): the real-pair strictness arm follows the key the latest bump added The arm stripped savedViewPlaces from the vendored schema, a key the library removed after 2.37.0, so it failed on the 2.42.0 copy. It now strips onDemand, the 2.42.0 addition, and asserts the key and the closed step are still there so a later bump says what to re-point instead of failing obscurely.
Contributor
|
Superseded by #815, which vendors manifest schema 2.42.0 (byte-identical to @conduction/nextcloud-vue 2.59.0) and validated it against 19 apps. 2.41.0 still lacks setup-step |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored manifest schema was at 2.37.0. @conduction/nextcloud-vue 2.57.1 ships 2.41.0.
Gates 22 and 53 validate every app's manifest against the vendored copy, so until this merges an app that adopts a key 2.41.0 added is rejected by the gate while its own
npm run check:manifestpasses.Before merging
CI resolves these gates at
@main, so this reaches all 21 swept apps the minute it lands. Constraints that got stricter in this diff:nonemeans the diff is additive and cannot redden a manifest that passes today. Anything else means it can, and the fleet's effective manifests need validating against both schemas first.Opened by .github/workflows/hydra-gates-schema-sync.yml. See #785 for why the vendored copy needs a keeper.