Skip to content

chore(openspec): verify-and-tick sweep (decidiq, part 1) - #1692

Open
rubenvdlinde wants to merge 4 commits into
developmentfrom
chore/openspec-sweep-1
Open

rubenvdlinde wants to merge 4 commits into
developmentfrom
chore/openspec-sweep-1

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Verify-and-tick sweep, part 1 (decision 141). No code, schema or test changed: only openspec/changes/*/tasks.md, the folded openspec/specs/*, and the archive. openspec validate --specs: 142 passed, 0 failed (135 passed, 0 failed on development before).

Skipped on purpose: the changes the paused build lane (build/openspecs-3) touched: meeting-ad-hoc-with-guests, pc-cyclus, woo-diwoo-publication, l10n-parity-ci-gate, security-flow-e2e-coverage.

Archived (13), only live/e2e tasks remained, code and unit tests verified

  • agenda-incoming-documents-list: IncomingDocumentsWidget.vue, tests/vitest/incomingDocuments.spec.js
  • bodies-board-composition-skills-and-diversity: GovernanceBodyCompositionTab.vue, tests/vitest/boardComposition.spec.js
  • bodies-substitute-mandate-swap: SeatHolderGuard wired in VoteCastingService, MandateSubstitutionServiceTest
  • live-public-livestream: MeetingBroadcastService, BroadcastCaptionService, PortalContributionProviderTest
  • participation-citizen-advisory-vote-on-motions: PortalCreateOpenParentGuardListener, CitizenAdviceController, register test
  • planning-parallel-sessions: ParallelSessionListenerTest, meetingSessionsTab.spec.js, meetingCalendarSessions.spec.js
  • configuration-surface, fold-regulations-into-governing-documents, generic-audit-statement, integrity-disclosures-in-plain-words, one-consultation-schema, retire-the-unbuilt-rooster: migration classes registered in info.xml with unit tests
  • document-approval-chain-leaf: leaf built under other names (RegisterApprovalChainLeafListener, ApprovalChainLeafParityTest, e2e specs)

Tasks ticked (24)

  • board-proxy-vote-authorization-guard: tasks 1-3 (ProxyVoteService::isChairOrClerk, ProxyVoteServiceTest); task 4 left (no unrelated-user suspend case in the Newman collection)
  • objection-advisory-committee: task 1 (register fields, ObjectionAdvisoryCommitteeFieldsTest)
  • action-item-deck-board: tasks 1-3 implementation (ActionItemsSurface, deckProjection.js, ActionItemDeckBoard) and the projection test; surface and board tests missing
  • dedupe-governance-controller-admin-guard: task 3
  • member-proxy-authorization: task 1
  • delegatie-mandaatregister, governing-documents-register, shared-governance-bodies, termijnagenda, works-council-consultation: register fragment / manifest pages implementation lines (tests not claimed)

Marked, not ticked

Live passes tagged "(decision 139)" in agenda-ai-paper-summaries, bodies-director-remuneration (Newman and Playwright specs not written), records-management-archiving, voting-ranked-preference-ballot, action-item-deck-board.

Needs a decision (QUESTIONS.md)

  • S1 dedupe-governance-controller-admin-guard: built as RequiresOrAdmin, not as the task text says
  • S2 audit-log-chain-tail-hash: target code (resolvePreviousHash) no longer exists
  • S3 objection-advisory-committee: governance-bodies:write scope is not enforced; seed and detail fields missing
  • S4 nine register-first changes whose Dutch-named schemas were since renamed or retired

Inherited / not done

Most remaining changes name services, dialogs and pages that do not exist (for example leaf-integrations, process-templates-as-lifecycle-policies, hermiq-ai-tooling, decidiq-mcp-adoption, voting-written-resolution): nothing ticked.

@rubenvdlinde
rubenvdlinde requested a review from Rem-Dam as a code owner October 10, 2026 08:38
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/decidiq @ 54ad255

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
check-nav-ceiling ✅
test-l10n ✅
format ✅
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 107/107
npm ✅ ✅ 652/652
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ⏭️ not run for this diff — no file in this diff matches the code globs, and none carries a source extension — the heavy tier has nothing to decide about it.
Newman ✅ 363/363 · 1 skipped
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-10-10 09:05 UTC

Download the full PDF report from the workflow artifacts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant