Skip to content

feat(approval): the approval chain leaf offers ready-made reasons from its host - #1695

Merged
rubenvdlinde merged 1 commit into
developmentfrom
build/dep-dossiq-approval-reason-templates
Oct 11, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
build/dep-dossiq-approval-reason-templates

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

CnApprovalChainWidget takes a reasonTemplates prop, [{ id, name, body }] (fallback integrationContext.reasonTemplates). When it is not empty, a "Start from a template" picker sits above the reason field, both when acting yourself and when acting on behalf. Picking one fills the reason; the person can still edit it. decidiq does not read any app's template library; it shows what the host passes.

Why

Dossiq offers content templates wherever a kind of text is written (starter-content-and-templates task 7.2, decision 156), and one kind is the approval reason. The leaf is a mount leaf from decidiq's own bundle, so a host cannot slot a picker into it.

Change

openspec/changes/approval-reason-templates (proposal, tasks, spec delta, screens.md: design backlog DcParafering, decision 157).

Verified locally

  • vitest run tests/vitest/approvalChainReasonTemplates.spec.js tests/vitest/approvalChainOnBehalf.spec.js: 11 tests green.
  • eslint on the changed files: 0 errors (3 inherited no-unused-properties warnings on existing props).
  • stylelint on the widget: 0.
  • node tests/l10n/check-l10n.js: OK. check-l10n-parity.js: fails on development too (79 nl keys missing in the frontend .js, inherited); this PR adds the nl string for its one new key.
  • No PHP touched, so composer check:strict was not run.

Consumer: dossiq passes its approval templates as reasonTemplates in a follow-up dossiq PR.

…asses as templates

CnApprovalChainWidget takes reasonTemplates ([{id, name, body}], fallback
integrationContext.reasonTemplates). When given, a 'Start from a template'
picker sits above the reason field (acting yourself and on behalf); picking
fills the reason, which stays editable. decidiq reads no app's template
library. For dossiq starter-content-and-templates 7.2 (decision 156).
Change: openspec/changes/approval-reason-templates.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/decidiq @ 1b7f498

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
check-nav-ceiling ✅
test-l10n ✅
format ✅
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 107/107
npm ✅ ✅ 652/652
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ✅ 2636/2636 · 8 skipped
Newman ✅ 363/363 · 1 skipped
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-10-10 15:17 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 513aabe into development Oct 11, 2026
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant