Repository navigation
feat(approval): the approval chain leaf offers ready-made reasons from its host - #1695
Merged
rubenvdlinde merged 1 commit intoOct 11, 2026
Merged
Conversation
…asses as templates
CnApprovalChainWidget takes reasonTemplates ([{id, name, body}], fallback
integrationContext.reasonTemplates). When given, a 'Start from a template'
picker sits above the reason field (acting yourself and on behalf); picking
fills the reason, which stays editable. decidiq reads no app's template
library. For dossiq starter-content-and-templates 7.2 (decision 156).
Change: openspec/changes/approval-reason-templates.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 10, 2026 15:12
Contributor
Quality Report — ConductionNL/decidiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-nav-ceiling | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 652/652 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 2636/2636 · 8 skipped | ||||
| Newman | ✅ 363/363 · 1 skipped | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-10 15:17 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CnApprovalChainWidgettakes areasonTemplatesprop,[{ id, name, body }](fallbackintegrationContext.reasonTemplates). When it is not empty, a "Start from a template" picker sits above the reason field, both when acting yourself and when acting on behalf. Picking one fills the reason; the person can still edit it. decidiq does not read any app's template library; it shows what the host passes.Why
Dossiq offers content templates wherever a kind of text is written (
starter-content-and-templatestask 7.2, decision 156), and one kind is the approval reason. The leaf is a mount leaf from decidiq's own bundle, so a host cannot slot a picker into it.Change
openspec/changes/approval-reason-templates(proposal, tasks, spec delta, screens.md: design backlog DcParafering, decision 157).Verified locally
vitest run tests/vitest/approvalChainReasonTemplates.spec.js tests/vitest/approvalChainOnBehalf.spec.js: 11 tests green.eslinton the changed files: 0 errors (3 inheritedno-unused-propertieswarnings on existing props).stylelinton the widget: 0.node tests/l10n/check-l10n.js: OK.check-l10n-parity.js: fails on development too (79 nl keys missing in the frontend.js, inherited); this PR adds the nl string for its one new key.composer check:strictwas not run.Consumer: dossiq passes its approval templates as
reasonTemplatesin a follow-up dossiq PR.