[rubenvdlinde]

method-decomposition slice 8h: StatusTransitionService.

Stacked on #3854 (decision 224), which is stacked on #3836. Three commits are this PR's own: the design, the characterisation test, the split.

What changes

The status engine coupled to 18 classes against a limit of 13 and took 14 constructor arguments. It carried two PHPMD suppressions for that. Both are gone.

The engine asked two kinds of question of fourteen collaborators. It now asks two classes.

The engine asks	New class	Over
What does this case declare about its status and its moves?	Transitions/CaseDeclarations	StatusDeclarations, TransitionDeclarations, OfferedTransitions, StatusChecklist, and the status row
What does a move write, and what did earlier moves write?	Transitions/CaseMoveLedger	CaseStatusStore, CaseResultWriter, SideEffectDispatcher

The engine keeps the decision: which transition, in which order the checks run, what is refused and what the caller hears. It takes nine arguments and couples to 12 classes.

The design is in openspec/changes/method-decomposition/design.md, "StatusTransitionService: two facades", written before the code. It ends with the two points where the build differs from the first draft, and why.

What does not change

• The public methods and their answers: getAvailableTransitions(), execute(), executeFreeForm(), replay(), isAdmin(), ADMIN_GROUP_ID.
• The 32 classes that inject the engine. The container builds both new classes by type.
• The seven classes behind the facades, their constructors and their tests.

The constructor of the engine does change. Nothing outside the tests builds it by hand.

How it is proven

1. Characterisation first, own commit (96fe20b), green on the single class: StatusTransitionServiceOrderTest, 10 tests. It pins what the five existing engine tests left open: the order of the five refusals, the conflict check, the one save of a closing move with the version it read, the timer after the save, the record that cannot be written back, the free-form refusals, and the shape of the available transitions. Seven mutations of the old engine turn it red.
2. The split (a3a1c0a): that test and the five existing ones are green with only their constructor call changed. No assertion was edited.
3. Own tests for the new classes: CaseDeclarationsTest (4), CaseMoveLedgerTest (6).

Debt

.debt-baseline.json: phpmd.suppressWarnings 182 to 180 (development's number after train 5, minus 2). Inherited: development itself measures 187 suppressions against its own 182 since #3884/#3888 etc., so the debt-ratchet check reads red on development and here (185 measured against 180).

Inherited, not fixed here

StatusTransitionService::writeMove() and a few listeners still cite openspec/changes/what-a-status-declares/..., archived on 7 October. The PR stacked on this one repoints all 206 of them.

Verified

On a3a1c0a, every composer check:strict stage, one at a time in the lane's check worktree (exit codes in dq-l11-logs/r6/s26.rc):

• lint 0, refusal-grounds snapshot 0, phpcs 0, phpmd 0 (whole tree, with both suppressions removed), psalm 0, phpstan 0.
• PHPUnit --no-coverage: 8,507 tests, 2 failures. Both are StubApiDriftTest (DecisionChangeRequestedEvent, DecisionVisibilityRequestedEvent), the stub drift train 4 fixes. Not in this diff.
• The nine engine and facade test classes under a coverage driver with fail-on-risky (pcov, 52 tests): no risky test.
• Hydra gates on the diff: 78 of 79 applicable ran, 8 failed, none in this diff (22 and 53 need node_modules; 23, 43, 51, 55, 104, 107 inherited). Gates 16 and 46 pass.
• openspec validate method-decomposition: valid.

Not run: npm run lint and vitest. No JavaScript, no l10n and no register change.

Live pass (decision 139): move a case through one status, close one with a result, and do one free-form move as an administrator.

Merged with development (14 Oct), verified again

#3854 is merged in, with development after train 5 (b99db82). .debt-baseline.json was the only conflict.

On b99db82, every composer check:strict stage once, one at a time in the lane's check worktree (exit codes in dq-l11-logs/r7/s26.rc):

• lint 0, refusal-grounds snapshot 0, phpcs 0, psalm 0, phpstan 0.
• phpmd 2: two findings, both BooleanArgumentFlag in lib/Service/Termijn/TermLetters.php (lines 401 and 425), which came to development with fix(letters): every date in a letter to the applicant reads the same way #3884/fix(portal): the Woo request form reads Dutch dates and names refused fields in Dutch #3895. Inherited, not in this stack.
• PHPUnit --no-coverage: 8,663 tests, exit 0, no failure (7 skipped, 1 warning).

[github-actions]

Quality Report — ConductionNL/dossiq @ 72291c0

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	❌
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-vue3-compile		✅
test-l10n		✅
format		❌
check-schema-l10n		✅
check-l10n-js		✅
check-debt-ratchet		❌
check-types-e2e		✅
composer			✅	✅ 109/109
npm			✅	✅ 659/659
app:check-code	⏭️
info.xml	✅
REUSE	❌
lockfile sync		✅
PHPUnit					❌ 8660/8660 · 3 skipped (no test failed, the job failed for another reason — see its log)
Newman					⏭️
Playwright					⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates					❌

---

Quality workflow — 2026-10-14 20:16 UTC

Download the full PDF report from the workflow artifacts.