Repository navigation
fix(example-sets): the Lindelaan saved search tells its owner - #4136
Merged
Merged
Conversation
OpenRegister refuses a view alert without recipients, so the Zuiddrecht install skipped zoek-lindelaan and DqZoekresultaten had no saved search. Thomas, the view's owner, is now its one recipient: since openregister#4685 only the owner or an administrator may name others. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
October 21, 2026 13:09
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-debt-ratchet | ❌ | ||||
| check-types-e2e | ✅ | ||||
| composer | ✅ | ✅ 109/109 | |||
| npm | ✅ | ✅ 658/658 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-21 13:24 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Zuiddrecht example set's saved search
zoek-lindelaannow names its owner, Thomas, as the alert's one recipient (user:{{cast:thomas.uid}}).OpenRegister refuses a view alert with no recipients ("alert.recipients: name at least one recipient"), so
occ openregister:example-set:install zuiddrechtskipped the view and the DqZoekresultaten board had no saved search to draw. Since openregister#4685 only the owner or an administrator may name someone else, so the owner is the recipient that always passes.Verified
ZuiddrechtSocialSearchContactTestasserts the recipient isuser:plus the owner; all nineZuiddrecht*Testfiles pass, phpcs is clean on the changed test.Not in this PR
MZ-ZDR-2026-0412that decidiq'sdecision-woo-lindelaan-conceptlooks up is portaliq's (woo-fietspad, seeZuiddrechtLindelaanIsPortaliqsTest), so dossiq does not add a second one.AI-assisted: written with Claude Code (claude-opus-5-5) and reviewed before submission.