Repository navigation
test(case): follow the renamed case widgets so development goes green - #4151
Merged
Merged
Conversation
Batch 25 renamed family-plan to goal-plan and case-pipelinq-contact-moments to linked-contact-moments, with RenamedLayoutIds rewriting stored layouts, and batch 28 moved the planned follow-ups and typed relations of the simple case page into case-related-cases-card. The code is right; eight specs in pipelinqCaseSurfaces and recordPageLibraryWidgets still read the old ids and the old simple card. They follow the new ones now, and two notes that said the ids would be renamed later say they were. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-debt-ratchet | ❌ | ||||
| check-types-e2e | ✅ | ||||
| composer | ✅ | ✅ 109/109 | |||
| npm | ✅ | ✅ 658/658 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-22 06:05 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Eight vitest specs in
pipelinqCaseSurfaces.spec.jsandrecordPageLibraryWidgets.spec.jsfail on development.Why they failed
The code is right and the tests were stale:
family-plantogoal-planandcase-pipelinq-contact-momentstolinked-contact-moments.RenamedLayoutIdsrewrites stored layouts to the new ids. The specs still looked up the old ids.case-related-cases-card, whichtypedRelatedCasesCard.spec.jscovers.case-related-cardkeeps only the parent case and Plan follow-up. The spec still expectedextraSourceson it.Change
_notes said these ids would be renamed later. They now say the ids were renamed.There is no runtime change.
Verified
npx vitest runon both files: 60 passed. On development: 8 failed.AI disclosure: prepared with Claude Code (claude-opus-5-5).
🤖 Generated with Claude Code