Repository navigation
fix(build): stop shipping packages Nextcloud core already provides - #2687
Merged
Merged
Conversation
The release tarball bundled vendor/symfony/console 7.4 (a direct require). Composer prepends every app autoloader in front of core's 3rdparty one, so integriq's copy replaced core's 6.4 for the whole instance and every occ command died on the Recommendations app's execute() signature. A post-install-cmd script now removes the 30 packages that Nextcloud 32, 33, 34 and 35 all ship in 3rdparty (symfony/console, http-foundation, event-dispatcher, string, uid, guzzle, psr/*, ...) from a --no-dev vendor tree and re-dumps the autoloader, so the release falls through to core's copies. Dev installs are untouched. The remaining packages' locked versions resolve against core's pinned versions on all four branches. Closes #2433 Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
October 15, 2026 17:50
Contributor
Quality Report — ConductionNL/integriq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 143/143 | |||
| npm | ✅ | ✅ 647/647 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 5490/5490 · 1 skipped | ||||
| Newman | ✅ 130/130 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ | ||||
| Hydra gates (axe) | ✅ |
Quality workflow — 2026-10-15 18:22 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2433.
Cause
symfony/console ^7.4is a directrequire, so the release'scomposer install --no-devput Console 7.4.16 invendor/. Composer prepends each app's autoloader in front of core's3rdpartyone, so afterocc app:enable integriqevery Console class came from integriq's copy. Core apps written for core's 6.4 (Recommendations'execute()has no: int) then fatal, and every occ command dies.Fix
scripts/prune-core-provided-vendor.php, run as the lastpost-install-cmd. It only acts whenCOMPOSER_DEV_MODE=0(the release workflow's--no-devinstall). It deletes the listed packages fromvendor/, removes them frominstalled.json/installed.phpand re-dumps the autoloader (--classmap-authoritative), so no classmap, PSR-4 orfilesentry points at a removed package.composer.jsonextra.nextcloud-core-provided: the 30 packages in integriq's runtime tree that nextcloud/3rdparty ships on all of stable32, stable33, stable34 and master (symfony/console, http-foundation, event-dispatcher, string, uid, dom-crawler, css-selector, service-contracts, deprecation-contracts, intl polyfills, guzzle, psr/*, brick/math, spomky-labs/pki-framework, ...). Packages only some branches ship (polyfill-php82, polyfill-php85) stay vendored.No
replaceblock was used because it would also drop the packages from dev installs (psalm and nextcloud/ocp need them). openregister and dossiq have noreplaceblock or vendor excludes to copy from.Verification
composer install --no-dev --optimize-autoloader --classmap-authoritative, as the shared workflow runs it):vendor/symfony/consoleis gone, along with all 30 listed packages. The autoloader loads cleanly and doesn't resolve Console.occ statusexit 0,occ app:listlists integriq and recommendations as enabled,occ app:disable/app:enable integriqworks,occ list integriqshows all 10 commands,occ recommendations:recommend adminexit 0. Before the swap, the same instance fataled on every occ command.composer check:strict: lint, phpcs, phpmd, psalm and phpstan are green. test:all has 11 errors intests/Unit/AppInfo, and the same 11 show up on development locally (a DIContainer typed-property mismatch, inherited; CI on development is green). The newPruneCoreProvidedVendorTestpasses.AI assistance: prepared with Claude Code.