Repository navigation
fix: third round of review fixes for the beta promotion (#2643) - #2694
Merged
Merged
Conversation
testARefusedWriteSendsTheRefusalOutAsOneLine checked only the Fo03 body, so logging the reason as the owning app gave it stayed green. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
StufZknController::inbound read php://input whole before checking the HMAC signature. It now reads through StufZknRequestBody, at most one byte past the 2 MiB ceiling the provider endpoint uses, and answers 413 for a larger body before the signature or the XML is looked at. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r side reads The zakLk01 creeerZaak carried the zaaktype as <zkn:zaaktype>, the initiator's BSN directly under <zkn:gerelateerde> and no <zkn:parameters>, so integriq's own StufProviderOperationMapper read it without a zaaktype, an initiator or a mutatiesoort. The message now carries parameters/mutatiesoort T with indicatorOvername V, the zaaktype under isVan/gerelateerde (ZAKZKT/ZKT), and each person under <role>/gerelateerde/natuurlijkPersoon. A round-trip test feeds the built message to the mapper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Quality Report — ConductionNL/integriq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 143/143 | |||
| npm | ✅ | ✅ 646/646 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 5557/5557 · 1 skipped | ||||
| Newman | ✅ 130/130 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ | ||||
| Hydra gates (axe) | ✅ |
Quality workflow — 2026-10-16 14:42 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third round of fixes for the development → beta promotion #2643. These are the follow-ups #2692 left until #2686 was merged.
What this fixes
0a0c2c55fparameters/mutatiesoortT withindicatorOvernameV, the zaaktype underisVan/gerelateerde(ZAKZKT/ZKT) and each person under<role>/gerelateerde/natuurlijkPersoon. A round-trip test feeds the built message toStufProviderOperationMapper::caseOperation()and gets the create, title, start date, zaaktype and initiator back.21f0ff26ctestARefusedWriteSendsTheRefusalOutAsOneLineasserts the logger'sreasonis the bounded outward line.ba01cdae1StufZknController::inboundreads throughStufZknRequestBody(at most 2 MiB plus one byte) and answers 413 for a larger body before the signature or the XML is looked at.Still open
zakLk01old/new pair rather than thezakLk02the builder sends needs a check against the ZDS 1.2 XSD, which is not in this repository. Until thencaseUpdate()is unchanged.sourceAppasconfiguration.owningApp, the BSN-roster unsubscribe flow, and fix(review): #2643 review findings, round 1 #2686's remaining items (aud-f3, the iq-f3 Microsoft 365 binding, the iq-f6 residue) are with the author.Checks run on this branch
bash hydra/scripts/run-hydra-gates.sh --scope-to-diff --base origin/development→ exit 0, COVERAGE 46 of 46 applicable gates ran (51 not applicable).phpcs,phpstanandphpmdon the two changedlib/files → clean.vendor/bin/phpunit -c phpunit-unit.xml: 5578 tests, 11 errors and 1 failure: thetests/Unit/AppInfo/Application*Testcontainer errors andEndoflifeDateLiveSyncTest(needs the live endpoint), which fail the same way ondevelopment.🤖 Generated with Claude Code