Skip to content

fix: third round of review fixes for the beta promotion (#2643) - #2694

Merged
WilcoLouwerse merged 3 commits into
developmentfrom
review/pr-2643-fixes-round3
Oct 16, 2026
Merged

WilcoLouwerse merged 3 commits into
developmentfrom
review/pr-2643-fixes-round3

Conversation

@WilcoLouwerse

Copy link
Copy Markdown
Contributor

Third round of fixes for the development → beta promotion #2643. These are the follow-ups #2692 left until #2686 was merged.

What this fixes

Finding Commit Change
🟡 The creeerZaak/actualiseerZaak integriq sends is not the shape integriq's own receiver reads (creeerZaak) 0a0c2c55f The zakLk01 creeerZaak now carries parameters/mutatiesoort T with indicatorOvername V, the zaaktype under isVan/gerelateerde (ZAKZKT/ZKT) and each person under <role>/gerelateerde/natuurlijkPersoon. A round-trip test feeds the built message to StufProviderOperationMapper::caseOperation() and gets the create, title, start date, zaaktype and initiator back.
#2692 review note: the log line of a refusal is not asserted 21f0ff26c testARefusedWriteSendsTheRefusalOutAsOneLine asserts the logger's reason is the bounded outward line.
#2686 heads-up: the legacy HMAC bridge reads its body unbounded ba01cdae1 StufZknController::inbound reads through StufZknRequestBody (at most 2 MiB plus one byte) and answers 413 for a larger body before the signature or the XML is looked at.

Still open

  • The actualiseerZaak half of the same thread: whether ZDS 1.2 updates a case with a zakLk01 old/new pair rather than the zakLk02 the builder sends needs a check against the ZDS 1.2 XSD, which is not in this repository. Until then caseUpdate() is unchanged.
  • The Symfony 6.4 thread (lower the constraints or add a CI job), iq-f5 (BRP relations, together with dossiq), sourceApp as configuration.owningApp, the BSN-roster unsubscribe flow, and fix(review): #2643 review findings, round 1 #2686's remaining items (aud-f3, the iq-f3 Microsoft 365 binding, the iq-f6 residue) are with the author.

Checks run on this branch

  • bash hydra/scripts/run-hydra-gates.sh --scope-to-diff --base origin/development → exit 0, COVERAGE 46 of 46 applicable gates ran (51 not applicable).
  • phpcs, phpstan and phpmd on the two changed lib/ files → clean.
  • vendor/bin/phpunit -c phpunit-unit.xml: 5578 tests, 11 errors and 1 failure: the tests/Unit/AppInfo/Application*Test container errors and EndoflifeDateLiveSyncTest (needs the live endpoint), which fail the same way on development.
  • Each new or changed assertion fails with its fix reverted (round-trip test, log reason, 413).
  • Not run: psalm (crashes in this environment while loading the autoloader files; CI runs it).

🤖 Generated with Claude Code

WilcoLouwerse and others added 3 commits October 16, 2026 16:29
testARefusedWriteSendsTheRefusalOutAsOneLine checked only the Fo03 body,
so logging the reason as the owning app gave it stayed green.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
StufZknController::inbound read php://input whole before checking the
HMAC signature. It now reads through StufZknRequestBody, at most one byte
past the 2 MiB ceiling the provider endpoint uses, and answers 413 for a
larger body before the signature or the XML is looked at.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r side reads

The zakLk01 creeerZaak carried the zaaktype as <zkn:zaaktype>, the
initiator's BSN directly under <zkn:gerelateerde> and no <zkn:parameters>,
so integriq's own StufProviderOperationMapper read it without a zaaktype,
an initiator or a mutatiesoort. The message now carries
parameters/mutatiesoort T with indicatorOvername V, the zaaktype under
isVan/gerelateerde (ZAKZKT/ZKT), and each person under
<role>/gerelateerde/natuurlijkPersoon. A round-trip test feeds the built
message to the mapper.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/integriq @ 854e2eb

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
build ✅
check-specs ✅
test-l10n ✅
format ✅
check-schema-l10n ✅
check-l10n-js ✅
composer ✅ ✅ 143/143
npm ✅ ✅ 646/646
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ✅ 5557/5557 · 1 skipped
Newman ✅ 130/130
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ✅
Hydra gates (axe) ✅

Quality workflow — 2026-10-16 14:42 UTC

Download the full PDF report from the workflow artifacts.

@WilcoLouwerse
WilcoLouwerse merged commit 4c78ea7 into development Oct 16, 2026
47 checks passed
@WilcoLouwerse
WilcoLouwerse deleted the review/pr-2643-fixes-round3 branch October 16, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant