Repository navigation
docs(openspec): archive pass, changes the code has delivered - #812
Merged
Merged
Conversation
Archives beta-surface-alignment, store-plane-dashboard-sharing, wizard-dataset-card-load and keyboard-accessible-widget-repositioning (ticked from code: the grid half landed in nextcloud-vue CnDashboardGrid).
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ⏭️ not run for this diff — no file in this diff matches the code globs, and none carries a source extension — the heavy tier has nothing to decide about it. | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-07 22:50 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archive pass (decision 85). Only
openspec/changes; no code.Archived
beta-surface-alignment: licence, product page, Dutch page path and docs aligned (appinfo/info.xmlbilingual summary, EUPL-1.2). New main specbeta-alignment.store-plane-dashboard-sharing:lib/Service/StoreService.php,lib/Controller/StoreController.php, store routes inappinfo/routes.php:36-37,src/components/admin/DashboardRegistrySettings.vueand their tests. Its delta used## NEW Requirements, which openspec does not read, so it was renamed## ADDED Requirements; the requirements are unchanged. New main specdashboard-store(9 requirements). The@spec/@e2etags that name the change directory keep resolving: gate 46 maps a change path to its archived copy.wizard-dataset-card-load:loadAction: load-demo-data(src/manifest.json:19). New main specfirst-time-setup.keyboard-accessible-widget-repositioning(0 of 11 ticked before): its tasks namedsrc/components/DashboardGrid.vue, deleted when the grid moved to nextcloud-vue. Every task ticked from code, with the citations at the top of its tasks.md: grid item role, name, tab stop, focus ring and Enter/Space in nextcloud-vueCnDashboardGrid.vue(35-38, 633, 845-867, 1055); the Move item (WidgetContextMenu.vue:26),src/modals/WidgetMovePanel.vue,nudgePlacement(useGridManager.js:248), the wiring inViews.vue:420,444, and the unit, e2e and a11y tests. 2 requirements added togrid-layout.Every new main spec got a real Purpose. The one
capabilities.jsonlink to these changes (build-keyboard) now points atopenspec/changes/archive/2026-10-07-keyboard-accessible-widget-repositioning, in this file's path form.Left open
add-launchpad-discovered-and-spend-analyticshas no checkboxes at all, so it is not a fully ticked change; left alone.Validate counts
openspec validate --specs --strict: before 71 passed / 9 failed, after 74 / 9 (the same 9 inherited specs).openspec validate --changes --strict: before 34 / 22 failed, after 31 / 21 (store-plane-dashboard-sharingleft the failing list; the other 21 are inherited).