Repository navigation
fix(l10n): every Dutch key once, and a spec that keeps it so - #857
Merged
Merged
Conversation
nl.json carried Flows, Reports and Store twice, nl.js fifteen keys. In nl.js the last copy won, so Set as default read "Instellen als standaard" and View mode "Weergave" while nl.json says "Als standaard instellen" and "Weergavemodus". The nl.json values stay.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 13, 2026 17:11
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 1953/1953 | ||||
| Newman | ✅ 224/224 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-13 17:15 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dutch catalogues carried keys twice. Parallel pull requests each appended the same key, and git merged both lines without a conflict.
What changed
l10n/nl.json: "Flows", "Reports" and "Store" appeared twice with the same value. One copy each is gone.l10n/nl.js(what the browser loads): fifteen keys appeared twice. In a JS object the LAST copy wins, so two of them showed a different word than the rest of the app:nl.jsonvalue).nl.jsonvalue).src/__tests__/l10nNoDuplicateKeys.spec.jsreads the raw text ofnl.jsonand of the object innl.jsand fails on a key that occurs twice. Approach copied from nextcloud-vuetests/l10n/catalogueNoDuplicateKeys.spec.js. A third case proves it finds a duplicate. On development's catalogues it fails (['Store', 'Reports', 'Flows']and fifteen keys in nl.js); with this change it passes.What a user sees
"Als standaard instellen" and "Weergavemodus" where they read "Instellen als standaard" and "Weergave". Nothing else changes.
Verified (local)
npm run lint: exit 0.npx vitest run --maxWorkers=2: exit 1, 965 of 965 tests pass, 121 of 122 files;tests/vitest/shared-instance.spec.tsfails to load (@vue/tsconfigabove the mount, same on development).npm run build: exit 0. No PHP changed.Left open
The other locale catalogues (be, bg, bs, ca, cs, da, de, el, es, et and more) each carry two duplicate keys too. The guard covers Dutch only; extending it means cleaning those first.