Repository navigation
fix(dialogs): dashboard settings in the board's three tabs - #859
Merged
Merged
Conversation
Details, Talen and Delen with a share count, as board LpDashboardInstellingen draws them. The default switch and the detail fields move under Details; nothing is removed. A caller that still asks for the old default tab lands on Details.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 1953/1953 | ||||
| Newman | ✅ 224/224 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-13 17:31 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard settings dialog has the board's three tabs: Details, Talen and Delen with a share count (board LpDashboardInstellingen). It had five: Algemeen, Delen, Standaard, Talen, Details.
What changed
general, so the share button in the top bar, the e2e tests and every caller keep working. A caller that asks for the olddefaulttab lands on Details.Nothing is removed: every field and switch is still in the dialog.
Verified (local)
npm run lint0, stylelint 0 (one inherited warning on line 1400,margin-left, not touched here).npx vitest run --maxWorkers=2: exit 1, 966 of 966 tests pass, 120 of 121 files;tests/vitest/shared-instance.spec.tsfails to load (@vue/tsconfigabove the mount, same on development). Four new tests: the three tabs in order, the default switch under Details, the olddefaulttab lands on Details, the share count.npm run build: exit 0. No PHP changed.LA/diffs-13/LpDashboardInstellingen-live.png.Left open
CnIconBrowser).