Skip to content

fix(dialogs): dashboard settings in the board's three tabs - #859

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/dialog-settings-three-tabs
Oct 13, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
fix/dialog-settings-three-tabs

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

The dashboard settings dialog has the board's three tabs: Details, Talen and Delen with a share count (board LpDashboardInstellingen). It had five: Algemeen, Delen, Standaard, Talen, Details.

What changed

  • The first tab is labelled Details. It holds what Algemeen held, then the default switch (was the Standaard tab), then the detail fields (was the Details tab).
  • Order: Details, Talen, Delen, as the board. Delen shows the number of shares once there is one.
  • The tab id stays general, so the share button in the top bar, the e2e tests and every caller keep working. A caller that asks for the old default tab lands on Details.
  • Two unused icon imports are gone.

Nothing is removed: every field and switch is still in the dialog.

Verified (local)

  • l10n parity 0, npm run lint 0, stylelint 0 (one inherited warning on line 1400, margin-left, not touched here).
  • npx vitest run --maxWorkers=2: exit 1, 966 of 966 tests pass, 120 of 121 files; tests/vitest/shared-instance.spec.ts fails to load (@vue/tsconfig above the mount, same on development). Four new tests: the three tabs in order, the default switch under Details, the old default tab lands on Details, the share count.
  • npm run build: exit 0. No PHP changed.
  • Pixel diff as pieter: LpDashboardInstellingen 47.12% (after fix(dialogs): dashboard settings and versions open in the board dialog frame #855) to 47.26%; LpDelen 64.33% (12 Oct) to 60.72%. The settings board shows the Details fields in two columns and a toggle row the dialog does not draw yet, so the structure change moves the total little. Screenshot: LA/diffs-13/LpDashboardInstellingen-live.png.

Left open

  • The Details panel is still one column; the board puts Titel and Bovenliggend dashboard side by side and shows the icon as a row of seven buttons with "Eigen afbeelding" (the icon browser is the library's CnIconBrowser).
  • The default switch label and hint sit on one line; the board puts the hint under the label.
  • Board fields with no backend: Thema, Taal van dit dashboard, Afdeling, Eigenaar, Bewaartermijn.

Details, Talen and Delen with a share count, as board
LpDashboardInstellingen draws them. The default switch and the detail
fields move under Details; nothing is removed. A caller that still asks
for the old default tab lands on Details.
@rubenvdlinde
rubenvdlinde merged commit 469944c into development Oct 13, 2026
32 of 34 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ 2ccb037

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ✅
composer ✅ ✅ 107/107
npm ✅ ✅ 636/636
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ✅ 1953/1953
Newman ✅ 224/224
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-10-13 17:31 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant