Skip to content

chore(deps): launchpad builds on nextcloud-vue 2.82.0 - #864

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/nextcloud-vue-2.82
Oct 13, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
fix/nextcloud-vue-2.82

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Launchpad moves to @conduction/nextcloud-vue ^2.82.0, the release after 2.81.0.

What changed

  • package.json and package-lock.json: 2.81.0 to 2.82.0. Nothing else.
  • The dist carries the merged library CSS: cn-store-page appears 33 times in dist/*.css, and dist/esm/library-style.js carries data-cn-library (#1569).
  • No workaround to remove. The app already imports the library stylesheet (fix(styles): launchpad loads the library stylesheet itself #861). The new nc-widget limit is per-placement content, and the library's widget form does not offer it yet, so there is nothing for the app to drop.

Verified (local, exit codes)

  • npm run build 0 (the same three asset-size warnings as on development)
  • npm run lint 0, npm run stylelint 0, l10n parity 0
  • npx vitest run --maxWorkers=2: exit 1. 969 of 969 tests pass, 121 of 122 files. tests/vitest/shared-instance.spec.ts fails to load because @vue/tsconfig is missing in the server tsconfig above the mount. That is inherited: the same failure shows on development.
  • PHPUnit --no-coverage 0: 1953 tests, 13 skipped. No PHP changed.

Pixel diff (development on 2.81.0, then this branch)

Board before after
LpStart 6.23 6.24
LpStore 6.63 6.60 (header 15.38 to 14.80)
LpBeheerAlgemeen 10.09 10.09
LpDashboardInstellingen 47.21 47.21
LpDelen 60.66 60.66
LpVersies 70.53 70.53
LpPersoonlijk 45.25 45.25
LpBewerken 16.94 16.94
LpWidgetKiezen 65.39 65.39

Nothing regresses. The admin page's board look comes in #862, which builds on this release.

🤖 Generated with Claude Code

The library stylesheet check holds on the new dist: cn-store-page is in
the CSS and library-style.js stamps data-cn-library. No app workaround
needed removing; the app already imports the library stylesheet (#861).
@rubenvdlinde
rubenvdlinde merged commit e726f83 into development Oct 13, 2026
32 of 34 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ 994adf7

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ✅
composer ✅ ✅ 107/107
npm ✅ ✅ 636/636
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ✅ 1953/1953
Newman ✅ 224/224
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-10-13 21:57 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant