Repository navigation
feat(example-sets): De Wilgenboom's own area follows its menu and phone boards - #1888
Draft
rubenvdlinde wants to merge 1 commit into
Draft
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Contributor
Quality Report — ConductionNL/learniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 110/110 | |||
| npm | ✅ | ✅ 747/747 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | 🚨 NO VERDICT — enabled but never ran | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ⏭️ |
Quality workflow — 2026-10-09 05:03 UTC
Download the full PDF report from the workflow artifacts.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
De Wilgenboom's own area follows boards MijnMenu and MobielHome. Lane LQ-wilgenboom.
What changes (only
lib/Settings/portals/po.json, on the portal)residentMenu.groupsas board MijnMenu:residentMenu.routes{"berichten": "messages"}.inboxis left out of the menu, because its notices stand on the conversations page (portaliq chore(release): 0.3.7-unstable.20260929104000 #1432).residentMenu.phoneHeader: "person", andfooter.compactwith "Telefoon: [telefoonnummer]", Toegankelijkheid and Privacy.contactPrompt: {show: false}: no board shows the e-mail prompt."Rapporten en documenten" points at the report cards page (
learniq:parentReportCards) until the documents page (lane FIX-P) lands.OpenSpec:
openspec/changes/wilgenboom-own-area-menu. Test:tests/Unit/Portal/WilgenboomOwnAreaTest.php. It also checks that every learniq page the menu names exists in the guardian's real manifest.Depends on (merge after)
portaliq #1423 (labelled items, routes), #1426 (contactPrompt) and #1434 (phoneHeader, footer.compact). The current portal schema refuses an object as a menu item.
Not in this change (lane FIX-L)
contactPromptinExamplePortalProvisioner::FILLABLE.perRecord), so this group shows a row per child. The board shows one item with a count.🤖 Generated with Claude Code