Repository navigation
feat(portal): Esdoornveen's public pages follow their boards - #1891
Draft
rubenvdlinde wants to merge 1 commit into
Draft
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Programme search, programme article with its right column, the sick report page with its melding and numbered steps, the breadcrumb by page title, the eHerkenning level line and plain Direct regelen icons (mbo.json only).
Contributor
Quality Report — ConductionNL/learniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 110/110 | |||
| npm | ✅ | ✅ 747/747 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | 🚨 NO VERDICT — enabled but never ran | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ⏭️ |
Quality workflow — 2026-10-09 05:04 UTC
Download the full PDF report from the workflow artifacts.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Esdoornveen's public pages as their boards draw them (lane LQ esdoornveen; proof run 3 findings), using the portaliq options merged on 9 October (#1422, #1424, #1425, #1427, #1430).
lib/Settings/portals/mbo.jsononly./opleidingensorts by best match, meta cards, hidden label, five a page; the board's intro line; the header search opens/opleidingen.breadcrumb: page; the eHerkenning card names level [NIVEAU].OpenSpec change:
openspec/changes/esdoornveen-public-pages-follow-the-boards.Depends on
Nothing to merge first. To take effect on a load,
breadcrumbmust be inExamplePortalProvisioner::FILLABLE(request to FIX-L); until then the other keys still work.Decisions
/aanmelden(the board names no address).ExamplePortalDeclarationsTest::testTheDeclarationsFollowTheBoards: under a content page's side list, plain cards are now allowed (the callouts change puts "Lukt inloggen niet?" there).Not here
FIX-L: programme cards have no href, duration, crebo or Richting facet (
PublicProgrammeIndex). portaliq: the pill above an article title, a photo placeholder, facts as tiles, "Wachtwoord vergeten?" as a link in a sign-in hint. Data: the board names five of nine techniek programmes.Verified (while building)
EsdoornveenPublicPagesTest(5 tests, all five fail on development's mbo.json),ExamplePortalDeclarationsTestgreen.python3 scripts/example-sets/mbo.py --check: up to date.Draft until the full verification run.
🤖 Generated with Claude Code