Skip to content

feat(portal): Esdoornveen's public pages follow their boards - #1891

Draft
rubenvdlinde wants to merge 1 commit into
developmentfrom
feat/esdoornveen-public-pages
Draft

rubenvdlinde wants to merge 1 commit into
developmentfrom
feat/esdoornveen-public-pages

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

Esdoornveen's public pages as their boards draw them (lane LQ esdoornveen; proof run 3 findings), using the portaliq options merged on 9 October (#1422, #1424, #1425, #1427, #1430). lib/Settings/portals/mbo.json only.

  • Zoeken: /opleidingen sorts by best match, meta cards, hidden label, five a page; the board's intro line; the header search opens /opleidingen.
  • Artikel (Mechatronica): lead, facts, "Wat leer je?" and "Zo ziet je week eruit" as headings, boxed table with row headers, Toelating and Na je diploma side by side; right column with the Aanmelden card and its button, Lesgeld and Boeken en gereedschap, "Eerst komen kijken?" with "Meeloopdag aanvragen", "Vraag over deze opleiding?".
  • Contentpagina (Ziek melden): lead, a melding with "Inloggen en ziek melden", "Zo werkt het" over numbered steps, row headers, "Ben je jonger dan 18?" plain, the side list tinted with "Lukt inloggen niet?" as a plain card under it.
  • Inloggen: breadcrumb: page; the eHerkenning card names level [NIVEAU].
  • Home: Direct regelen icons plain. News article: section "Nieuws" in the trail and the pill.

OpenSpec change: openspec/changes/esdoornveen-public-pages-follow-the-boards.

Depends on

Nothing to merge first. To take effect on a load, breadcrumb must be in ExamplePortalProvisioner::FILLABLE (request to FIX-L); until then the other keys still work.

Decisions

  • "Meeloopdag aanvragen" links to /aanmelden (the board names no address).
  • Lesgeld and Boeken en gereedschap stand as a description list under the Aanmelden card (a melding holds no list).
  • ExamplePortalDeclarationsTest::testTheDeclarationsFollowTheBoards: under a content page's side list, plain cards are now allowed (the callouts change puts "Lukt inloggen niet?" there).

Not here

FIX-L: programme cards have no href, duration, crebo or Richting facet (PublicProgrammeIndex). portaliq: the pill above an article title, a photo placeholder, facts as tiles, "Wachtwoord vergeten?" as a link in a sign-in hint. Data: the board names five of nine techniek programmes.

Verified (while building)

  • PHPUnit EsdoornveenPublicPagesTest (5 tests, all five fail on development's mbo.json), ExamplePortalDeclarationsTest green.
  • python3 scripts/example-sets/mbo.py --check: up to date.
  • No live look: swapping the proof instance's site bundle was not allowed from this lane.

Draft until the full verification run.

🤖 Generated with Claude Code

Programme search, programme article with its right column, the sick report
page with its melding and numbered steps, the breadcrumb by page title, the
eHerkenning level line and plain Direct regelen icons (mbo.json only).
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/learniq @ a3980d7

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-specs ✅
format ✅
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 110/110
npm ✅ ✅ 747/747
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit 🚨 NO VERDICT — enabled but never ran
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ⏭️

Quality workflow — 2026-10-09 05:04 UTC

Download the full PDF report from the workflow artifacts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant