Repository navigation
feat(credentials): the certificate keeps its wallet offer link while the offer is open - #1902
Open
rubenvdlinde wants to merge 1 commit into
Open
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
…the offer is open - credential 0.3.5 (register 0.41.1, app version raised so an upgrade imports it): walletOfferUri, the openid-credential-offer:// link a wallet app opens. offer() stores integriq's offerUrl (built from credentialOfferUri when missing) and clears it on a failed offer; a claim and a revocation clear it, a revocation even when integriq could not be told. - WalletOfferTokenCheck: the admin overview names learniq.openconnector_api_token while it is empty, a warning once an offer failed on it. - Participant portal "My certificates": a qr column with "Add to wallet" (portaliq link-field-qr-code T10); linkLabel is translated. - The spec names offerUrl, not credentialOfferUri: the latter is the offer's JSON address, not the link a wallet opens. OpenSpec: credential-wallet-offer-for-the-learner (1.1-1.4, 3.1; the learner section waits on board LqLlCertificaat). Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/learniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 110/110 | |||
| npm | ✅ | ✅ 747/747 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 3381/3381 · 5 skipped (no test failed, the job failed for another reason — see its log) | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-15 19:37 UTC
Download the full PDF report from the workflow artifacts.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
credential-wallet-offer-for-the-learner, the backend and the portal column. The learner section on the certificate page waits (see below).What changes
walletOfferUri, the link a wallet app opens.offer()stores integriq'sofferUrl(openid-credential-offer://?credential_offer_uri=..., the same value asqrPayload), or builds that link fromcredentialOfferUriwhenofferUrlis missing. A failed offer clears it.WalletOfferTokenCheck: the admin overview nameslearniq.openconnector_api_tokenwhile it is empty. It warns once an offer has failed on the missing token, and is only a note before any offer was tried, so a school without wallets is not nagged.qrcolumn "Wallet" with the link "Add to wallet" (portaliqlink-field-qr-codeT10). Alinkcolumn cannot carry it, because portaliq follows only http(s) and site links there.linkLabelis now a translated manifest key.Spec amended
The change said to store
credentialOfferUri. In integriq'sEudiWalletController::createOfferthat is the offer's JSON address. The link a wallet opens isofferUrl, which the design (D1) meant. The spec now namesofferUrl.Not in this PR
Tasks 2.x and 4.x, the learner's section on
CredentialDetail. BoardLqLlCertificaat(named in #1892) draws the learner's own certificate page with "Naar wallet" and "Nieuwe code maken". That is the learner starting an offer, which design D2 rules out (the holder has no update right; a learner route with system rights would be a write bypass). This needs a decision before the UI is built.Verification (on 2769da5)
tests/Unit/Service811,Portal165,Settings443,Listener659,Lifecycle369,Register119,AppInfo18,SetupCheck3, all OK. New:CredentialWalletOfferUriRegisterTestvalidates a training-set credential with the real link against the shipped fragment with Opis;WalletOfferTokenCheckTest.--threads=1on the changed files: exit 0.validate-register,check-l10n-parity --ratchet,check-schema-l10n(2151, at baseline): pass.Application.php, a file this PR touches but not on that line). Gate 101 names ConferenceInvitation and WerkprocesProgress, not credential.composer check:strictwas not run locally; CI is the full check.This PR was prepared with AI assistance (Claude Code).