Repository navigation
feat(fields): an ordered list a user keeps, with the keyboard - #1763
Closed
rubenvdlinde wants to merge 4 commits into
Closed
rubenvdlinde wants to merge 4 commits into
rubenvdlinde wants to merge 4 commits into
Conversation
CnOrderedListField draws rows in order with move up, move down and remove buttons, announces every change, and adds rows from a search-as-you-type picker; the app supplies the choices and gets update:modelValue (board DqPersoonlijkeInstellingen, "Zaaktypen in mijn menu"). Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 17, 2026 10:05
…ist-field # Conflicts: # l10n/en.json # l10n/nl.json
Contributor
Quality Report — ConductionNL/nextcloud-vue @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ⏭️ | ||||
| phpcs | ⏭️ | ||||
| phpmd | ⏭️ | ||||
| psalm | ⏭️ | ||||
| phpstan | ⏭️ | ||||
| phpmetrics | ⏭️ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| test | ✅ | ||||
| check-build | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| check-public-safe | ✅ | ||||
| check-journey-vocabulary | ✅ | ||||
| check-docs | ✅ | ||||
| check-docs-mdx | ✅ | ||||
| check-jsdoc | ✅ | ||||
| check-integration-parity | ✅ | ||||
| check-peers | ✅ | ||||
| check-docs-fresh | ✅ | ||||
| check-a11y | ✅ | ||||
| check-smoke | ✅ | ||||
| composer | ✅ | ✅ | |||
| npm | ✅ | ✅ 643/643 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ⏭️ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ | ||||
| Hydra gates | ⏭️ |
Quality workflow — 2026-10-17 10:21 UTC
Download the full PDF report from the workflow artifacts.
…ist-field # Conflicts: # l10n/en.json # l10n/nl.json
Contributor
Quality Report — ConductionNL/nextcloud-vue @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ⏭️ | ||||
| phpcs | ⏭️ | ||||
| phpmd | ⏭️ | ||||
| psalm | ⏭️ | ||||
| phpstan | ⏭️ | ||||
| phpmetrics | ⏭️ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| test | ✅ | ||||
| check-build | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| check-public-safe | ✅ | ||||
| check-journey-vocabulary | ✅ | ||||
| check-docs | ✅ | ||||
| check-docs-mdx | ✅ | ||||
| check-jsdoc | ✅ | ||||
| check-integration-parity | ✅ | ||||
| check-peers | ✅ | ||||
| check-docs-fresh | ✅ | ||||
| check-a11y | ✅ | ||||
| check-smoke | ✅ | ||||
| composer | ✅ | ✅ | |||
| npm | ✅ | ✅ 643/643 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ⏭️ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ | ||||
| Hydra gates | ⏭️ |
Quality workflow — 2026-10-17 10:45 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Author
|
Landed in batch 8 via #1771. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Board DqPersoonlijkeInstellingen has "Zaaktypen in mijn menu" in the personal settings: a list the user orders, a remove button per row, and "Zaaktype toevoegen" as a search-as-you-type picker. The library had no control for an ordered, user-kept list.
CnOrderedListField(exported): the values ofmodelValuein order as an<ol>labelled bylabel; per row a named move up, move down and remove button (first-up and last-down disabled); focus stays on a move button after the move.NcSelectpicker withinputLabel(addLabel) offers the choices not listed yet and adds the picked one at the end. Withsearchableit emitssearchwith the typed text and leaves filtering to the app (loadingwhile it fetches).optionsand getsupdate:modelValue, sov-modelworks.emptyTextanddisabled(read-only) too. Copy in nl + en. No schema change.Verified locally:
tests/components/CnOrderedListField.spec.js(new),tests/a11y/CnOrderedListField.a11y.spec.js(new, axe on the real @nextcloud/vue: no WCAG 2.1 AA violations with rows, empty and read-only; named native buttons; live region),tests/l10n/,tests/packaging/, eslint + stylelint on changed files, check:jsdoc, check:docs, check:docs-mdx, generated reference pages regenerated. Full jest, docs-fresh, build and e2e are left to CI.AI disclosure: written with Claude Code (claude-opus-5-5).
🤖 Generated with Claude Code