Repository navigation
feat(app-root): the board settings dialog shows one section at a time - #1767
Closed
rubenvdlinde wants to merge 7 commits into
Closed
rubenvdlinde wants to merge 7 commits into
rubenvdlinde wants to merge 7 commits into
Conversation
…tion, and heading icons Under the board look the user settings navigation can list Nextcloud's own personal settings first, as links (userSettingsNextcloudLinks), then one entry named after the app holding its sections, and a section's #icon also stands before its heading (board DqPersoonlijkeInstellingen). Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Under the board look the user settings dialog shows only the section of the current navigation entry (board DqPersoonlijkeInstellingen); the others stay mounted but hidden, so what was typed survives a switch, and switching moves focus to the shown section's heading. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn and
remko48
as code owners
October 17, 2026 10:26
Contributor
Quality Report — ConductionNL/nextcloud-vue @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ⏭️ | ||||
| phpcs | ⏭️ | ||||
| phpmd | ⏭️ | ||||
| psalm | ⏭️ | ||||
| phpstan | ⏭️ | ||||
| phpmetrics | ⏭️ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| test | ✅ | ||||
| check-build | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| check-public-safe | ✅ | ||||
| check-journey-vocabulary | ✅ | ||||
| check-docs | ✅ | ||||
| check-docs-mdx | ✅ | ||||
| check-jsdoc | ✅ | ||||
| check-integration-parity | ✅ | ||||
| check-peers | ✅ | ||||
| check-docs-fresh | ✅ | ||||
| check-a11y | ✅ | ||||
| check-smoke | ✅ | ||||
| composer | ✅ | ✅ | |||
| npm | ✅ | ✅ 643/643 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ⏭️ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ | ||||
| Hydra gates | ⏭️ |
Quality workflow — 2026-10-17 10:32 UTC
Download the full PDF report from the workflow artifacts.
…ings-one-section # Conflicts: # docs/components/cn-app-root.md # src/components/CnUserSettingsDialog/CnUserSettingsDialog.vue # tests/a11y/CnUserSettingsDialog.a11y.spec.js
Contributor
Quality Report — ConductionNL/nextcloud-vue @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ⏭️ | ||||
| phpcs | ⏭️ | ||||
| phpmd | ⏭️ | ||||
| psalm | ⏭️ | ||||
| phpstan | ⏭️ | ||||
| phpmetrics | ⏭️ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| test | ✅ | ||||
| check-build | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| check-public-safe | ✅ | ||||
| check-journey-vocabulary | ✅ | ||||
| check-docs | ✅ | ||||
| check-docs-mdx | ✅ | ||||
| check-jsdoc | ✅ | ||||
| check-integration-parity | ✅ | ||||
| check-peers | ✅ | ||||
| check-docs-fresh | ✅ | ||||
| check-a11y | ✅ | ||||
| check-smoke | ✅ | ||||
| composer | ✅ | ✅ | |||
| npm | ✅ | ✅ 643/643 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ⏭️ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ | ||||
| Hydra gates | ⏭️ |
Quality workflow — 2026-10-17 10:53 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Author
|
Landed in batch 8 via #1771. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Board DqPersoonlijkeInstellingen shows only the panel of the selected navigation entry. The board user settings dialog showed every section one under another, so "Zaaktypen in mijn menu" ran into "Meldingen" with its long table (BLD-Dq-E, measured live).
hidden), so what was typed in them survives a switch.tabindex="-1"), and the entry keepsaria-current="true".Stacked on #1765 (branched from
feat/user-settings-nav-groups, which adds the Nextcloud links and heading icons); merge #1765 first, then this diff is just the one-section change.Verified locally:
tests/components/CnUserSettingsDialogOneSection.spec.js(new, 2/2 fail without the change),CnUserSettingsDialog.spec.js,CnUserSettingsDialogGroups.spec.js,CnAppRoot.userSettingsSections.spec.js(via heavy.sh),tests/a11y/CnUserSettingsDialog.a11y.spec.js(extended: axe on the real @nextcloud/vue over the dialog body with one section shown and one hidden), eslint + stylelint on changed files, check:jsdoc, check:docs, check:docs-mdx, generated reference pages regenerated. Full jest, docs-fresh, build and e2e are left to CI.AI disclosure: written with Claude Code (claude-opus-5-5).
🤖 Generated with Claude Code